Avoid restyling elements that aren't in a document #14845

Merged
merged 1 commit into from Jan 4, 2017

Projects

None yet

5 participants

@jdm
Member
jdm commented Jan 4, 2017 edited
  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #14480
  • There are tests for these changes

This change is Reviewable

@highfive
highfive commented Jan 4, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/document.rs, components/script/layout_wrapper.rs
  • @kichjang: components/script/dom/document.rs, components/script/layout_wrapper.rs
@jdm jdm Only pass nodes to layout for restyling that are actually in the docu…
…ment.
9a264c8
@emilio
Member
emilio commented Jan 4, 2017

@bors-servo r+

Thanks for writing the test :)

@bors-servo
Contributor

📌 Commit 9a264c8 has been approved by emilio

@highfive highfive assigned emilio and unassigned Wafflespeanut Jan 4, 2017
@bors-servo
Contributor

⌛️ Testing commit 9a264c8 with merge 2fe914e...

@bors-servo bors-servo added a commit that referenced this pull request Jan 4, 2017
@bors-servo bors-servo Auto merge of #14845 - jdm:restyle-ood, r=emilio
Avoid restyling elements that aren't in a document

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14480
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14845)
<!-- Reviewable:end -->
2fe914e
@bors-servo bors-servo merged commit 9a264c8 into servo:master Jan 4, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment