Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid restyling elements that aren't in a document #14845

Merged
merged 1 commit into from Jan 4, 2017
Merged

Avoid restyling elements that aren't in a document #14845

merged 1 commit into from Jan 4, 2017

Conversation

@jdm
Copy link
Member

jdm commented Jan 4, 2017 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #14480
  • There are tests for these changes

This change is Reviewable
@highfive
Copy link

highfive commented Jan 4, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/document.rs, components/script/layout_wrapper.rs
  • @KiChjang: components/script/dom/document.rs, components/script/layout_wrapper.rs
@jdm
Only pass nodes to layout for restyling that are actually in the docu…
Loading status checks…
9a264c8 
…ment.
@jdm jdm force-pushed the jdm:restyle-ood branch from 232386f to 9a264c8 Jan 4, 2017
@emilio
Copy link
Member

emilio commented Jan 4, 2017

@bors-servo r+

Thanks for writing the test :)
@bors-servo
Copy link
Contributor

bors-servo commented Jan 4, 2017

📌 Commit 9a264c8 has been approved by emilio
@highfive highfive assigned emilio and unassigned wafflespeanut Jan 4, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jan 4, 2017

⌛ Testing commit 9a264c8 with merge 2fe914e...
bors-servo added a commit that referenced this pull request Jan 4, 2017
@bors-servo
Auto merge of #14845 - jdm:restyle-ood, r=emilio
Loading status checks…
2fe914e 
Avoid restyling elements that aren't in a document

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14480
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14845)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 4, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
@bors-servo bors-servo merged commit 9a264c8 into servo:master Jan 4, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Assertion failure when logging into gmail
5 participants
@jdm @highfive @emilio @bors-servo @wafflespeanut
You can’t perform that action at this time.