Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upanimation-iteration-count property is a number instead of integer. #14851
Conversation
highfive
commented
Jan 5, 2017
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. |
highfive
commented
Jan 5, 2017
|
This looks great. One last thing this PR would need to do is to check the animation state more often (see the caller of tick()). If you don't want to make that part of this PR (which is fine IMO since this doesn't regress functionality), please file an issue and cc me on it. r=me with any of those Thanks once again for the patch :) |
|
@emilio can you please tell me about the animation state check in more detail? I don't quite understand what 'more often' means. |
|
So right now we call With this patch, thinks like |
|
Awesome, thanks for filling it! @bors-servo r+ |
|
|
animation-iteration-count property is a number instead of integer. <!-- Please describe your changes on the following line: --> This is a revised PR for #14732. @emilio? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14851) <!-- Reviewable:end -->
|
|
hiikezoe commentedJan 5, 2017
•
edited by larsbergstrom
This is a revised PR for #14732.
@emilio?
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is