Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CallSetup. #14859

Merged
merged 1 commit into from Jan 5, 2017
Merged

Simplify CallSetup. #14859

merged 1 commit into from Jan 5, 2017
+14 −21

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 5, 2017 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Simplify CallSetup.
Loading status checks…
8d633fe
@highfive
Copy link

highfive commented Jan 5, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/callback.rs
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/callback.rs
@highfive
Copy link

highfive commented Jan 5, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Jan 5, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2017

📌 Commit 8d633fe has been approved by nox
@highfive highfive assigned nox and unassigned asajeffrey Jan 5, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2017

⌛ Testing commit 8d633fe with merge bb3cd4e...
bors-servo added a commit that referenced this pull request Jan 5, 2017
@bors-servo
Auto merge of #14859 - servo:CallSetup, r=nox
Loading status checks…
bb3cd4e 
Simplify CallSetup.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14859)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2017

💔 Test failed - mac-rel-wpt1
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jan 5, 2017

@bors-servo retry #14323
@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2017

⌛ Testing commit 8d633fe with merge 839b7fe...
bors-servo added a commit that referenced this pull request Jan 5, 2017
@bors-servo
Auto merge of #14859 - servo:CallSetup, r=nox
Loading status checks…
839b7fe 
Simplify CallSetup.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14859)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
@bors-servo bors-servo merged commit 8d633fe into master Jan 5, 2017
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the CallSetup branch Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @nox @bors-servo @asajeffrey
You can’t perform that action at this time.