Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow cli prefs to have numerical value #14863
Merged
Conversation
highfive
commented
Jan 5, 2017
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon. |
|
r? @jdm |
|
Nice tests! I only have a couple of suggestions. |
components/config/opts.rs
Outdated
| match value { | ||
| Some(&"false") => PREFS.set(pref_name, PrefValue::Boolean(false)), | ||
| Some(&"true") | None => PREFS.set(pref_name, PrefValue::Boolean(true)), | ||
| _ => { |
This comment has been minimized.
This comment has been minimized.
components/config/opts.rs
Outdated
| @@ -946,6 +939,22 @@ pub fn set_defaults(opts: Opts) { | |||
| } | |||
| } | |||
|
|
|||
| pub fn parse_opt_prefs(pref: &str) { | |||
This comment has been minimized.
This comment has been minimized.
|
@jdm this should be OK If you have another idea of work to do for me don't hesitate! |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 5, 2017
Allow cli prefs to have numerical value I'm not sure as I'm new with servo but shouldn't the new function ```parse_opt_prefs``` be in ```prefs.rs``` instead of ```opts.rs``` ? <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14842 <!-- Either: --> - [X] There are tests for these changes OR <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14863) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
charlesvdv commentedJan 5, 2017
•
edited by jdm
I'm not sure as I'm new with servo but shouldn't the new function
parse_opt_prefsbe inprefs.rsinstead ofopts.rs?./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is