Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove some unsound JSVal handling in JsTimerTask::invoke. #14864
+2
−7
Conversation
We were using Handles to *copies* of the traced values, rather than the originals.
highfive
commented
Jan 5, 2017
highfive
commented
Jan 5, 2017
|
|
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 5, 2017
Remove some unsound JSVal handling in JsTimerTask::invoke. We were using Handles to *copies* of the traced values, rather than the originals. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14864) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Jan 5, 2017
Remove some unsound JSVal handling in JsTimerTask::invoke. We were using Handles to *copies* of the traced values, rather than the originals. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14864) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedJan 5, 2017
•
edited by larsbergstrom
We were using Handles to copies of the traced values, rather than the
originals.
This change is