Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DOMImplementation skeleton #1488

Merged
merged 1 commit into from Jan 14, 2014
Merged

Add DOMImplementation skeleton #1488

merged 1 commit into from Jan 14, 2014

Conversation

@brunoabinader
Copy link
Contributor

brunoabinader commented Jan 13, 2014

Creates a DOMImplementation struct corresponding to DOMImplementation
WebIDL. Also implements a getter for Document::implementation.

Closes #1486.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 13, 2014

Critic review: https://critic.hoppipolla.co.uk/r/549

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@brunoabinader
Add DOMImplementation skeleton
Loading status checks…
60dd40f 
Creates a DOMImplementation struct corresponding to DOMImplementation
WebIDL. Also implements a getter for Document::implementation.

Closes #1486.
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 60dd40f Jan 14, 2014

saw approval from Ms2ger
at https://github.com/brunoabinader/servo/commit/60dd40f41258402c5b9358986fb71c7dd9b3dc6b

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 14, 2014

merging brunoabinader/servo/document-implementation = 60dd40f into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 14, 2014

brunoabinader/servo/document-implementation = 60dd40f merged ok, testing candidate = 32bf796

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 14, 2014

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/800
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/755

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 14, 2014

fast-forwarding master to auto = 32bf796
bors-servo pushed a commit that referenced this pull request Jan 14, 2014
bors-servo
auto merge of #1488 : brunoabinader/servo/document-implementation, r=…
32bf796 
…Ms2ger

Creates a DOMImplementation struct corresponding to DOMImplementation
WebIDL. Also implements a getter for Document::implementation.

Closes #1486.
@bors-servo bors-servo merged commit 60dd40f into servo:master Jan 14, 2014
1 check passed
1 check passed
default all tests passed
@brunoabinader brunoabinader deleted the brunoabinader:document-implementation branch Jan 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Add DOMImplementation skeleton
3 participants
@brunoabinader @hoppipolla-critic-bot @bors-servo
You can’t perform that action at this time.