Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCleaned up ripples due to MutJS to JS type change #14891
Merged
Conversation
highfive
commented
Jan 6, 2017
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon. |
highfive
commented
Jan 6, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jan 6, 2017
|
|
|
@bors-servo: r+ |
|
|
components/script/dom/bluetooth.rs
Outdated
| @@ -15,7 +15,7 @@ use dom::bindings::codegen::Bindings::EventHandlerBinding::EventHandlerNonNull; | |||
| use dom::bindings::codegen::UnionTypes::StringOrUnsignedLong; | |||
| use dom::bindings::error::Error::{self, Network, NotFound, Security, Type}; | |||
| use dom::bindings::error::Fallible; | |||
| use dom::bindings::js::{MutJS, Root}; | |||
| use dom::bindings::js::{ JS, Root}; | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r- Please remove the whitespace between |
|
Okay. Made the changes. |
|
Nice, thanks @prampey! @bors-servo r=jdm,emilio |
|
|
|
That's weird. |
|
@prampey no worries, that's known and won't block your PR from merging :) |
|
Oh okay. Thanks :) |
bors-servo
added a commit
that referenced
this pull request
Jan 7, 2017
Cleaned up ripples due to MutJS to JS type change <!-- Please describe your changes on the following line: --> Changed all Mutable JS values to JS values in the following files and fixed any differences that might have been caused due to type change. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14649 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because minimal type changes made. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14891) <!-- Reviewable:end -->
|
|
|
It says linking failed with no other output. I suspect the builder is running out of disk space or something like that, but let's see if it keeps happening: |
bors-servo
added a commit
that referenced
this pull request
Jan 7, 2017
Cleaned up ripples due to MutJS to JS type change <!-- Please describe your changes on the following line: --> Changed all Mutable JS values to JS values in the following files and fixed any differences that might have been caused due to type change. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14649 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because minimal type changes made. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14891) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
prampey commentedJan 6, 2017
•
edited by larsbergstrom
Changed all Mutable JS values to JS values in the following files and fixed any differences that might have been caused due to type change.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is