Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: support content property #14905

Merged
merged 2 commits into from Jan 8, 2017
Merged

stylo: support content property #14905

merged 2 commits into from Jan 8, 2017

Conversation

@heycam
Copy link
Member

heycam commented Jan 7, 2017 •
edited by larsbergstrom

This is the Servo-side of https://bugzilla.mozilla.org/show_bug.cgi?id=1315155, which @Manishearth has already reviewed.

This change is Reviewable
heycam added 2 commits Jan 7, 2017
@heycam
stylo: Regenerate bindings.
8f1f94d
@heycam
stylo: Stop setting the now-removed nsStyleContentData::mImageTracked.
Loading status checks…
95e5e79
@highfive
Copy link

highfive commented Jan 7, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/gecko_bindings/structs_debug.rs, components/style/gecko_bindings/structs_release.rs
  • @emilio: components/style/properties/gecko.mako.rs, components/style/gecko_bindings/structs_debug.rs, components/style/gecko_bindings/structs_release.rs
@highfive
Copy link

highfive commented Jan 7, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@heycam
Copy link
Member Author

heycam commented Jan 7, 2017

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2017

📌 Commit 95e5e79 has been approved by Manishearth
@highfive highfive assigned Manishearth and unassigned Ms2ger Jan 7, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2017

⌛ Testing commit 95e5e79 with merge 5d796a5...
bors-servo added a commit that referenced this pull request Jan 8, 2017
@bors-servo
Auto merge of #14905 - heycam:content, r=Manishearth
Loading status checks…
5d796a5 
stylo: support content property

This is the Servo-side of https://bugzilla.mozilla.org/show_bug.cgi?id=1315155, which @Manishearth has already reviewed.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14905)
<!-- Reviewable:end -->
@bors-servo bors-servo mentioned this pull request Jan 8, 2017
Merged
3 of 3 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
@bors-servo bors-servo merged commit 95e5e79 into servo:master Jan 8, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jan 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@heycam @highfive @bors-servo @Ms2ger @Manishearth
You can’t perform that action at this time.