Give up on hoisting ElementData into the frame and eliminate the concept of consuming styles #14907

bholley · 2017-01-07T03:18:08Z

Servo PR for the work in https://bugzilla.mozilla.org/show_bug.cgi?id=1325734

This change is

highfive · 2017-01-07T03:18:12Z

Heads up! This PR modifies the following files:

@KiChjang: components/script_layout_interface/wrapper_traits.rs, components/script/layout_wrapper.rs
@fitzgen: components/script_layout_interface/wrapper_traits.rs, components/script/layout_wrapper.rs
@emilio: components/style/gecko_bindings/bindings.rs, components/layout/fragment.rs, components/layout/traversal.rs, ports/geckolib/glue.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/data.rs, components/style/gecko_bindings/structs_debug.rs, components/style/dom.rs, components/style/gecko/wrapper.rs, components/layout/wrapper.rs, components/style/traversal.rs, components/layout/data.rs, components/style/matching.rs

highfive · 2017-01-07T03:18:13Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify style, layout, and script code, but no tests are modified. Please consider adding a test!

bholley · 2017-01-07T03:18:14Z

@bors-servo try

bors-servo · 2017-01-07T03:18:17Z

⌛ Trying commit be67bc5 with merge 58b38d6...


        Auto merge of #14907 - bholley:eliminate_consume, r=<try>

Give up on hoisting ElementData into the frame and eliminate the concept of consuming styles Servo PR for the work in https://bugzilla.mozilla.org/show_bug.cgi?id=1325734

bors-servo · 2017-01-07T03:54:58Z

💔 Test failed - linux-rel-wpt

bholley · 2017-01-07T04:48:52Z

@bors-servo try

bors-servo · 2017-01-07T04:48:56Z

⌛ Trying commit ffedd27 with merge 4647079...


        Auto merge of #14907 - bholley:eliminate_consume, r=<try>

Give up on hoisting ElementData into the frame and eliminate the concept of consuming styles Servo PR for the work in https://bugzilla.mozilla.org/show_bug.cgi?id=1325734  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14907)

bors-servo · 2017-01-07T05:44:22Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev

bholley · 2017-01-08T21:24:55Z

@bors-servo try

bors-servo · 2017-01-08T21:24:57Z

⌛ Trying commit 9570ef3 with merge ff389fd...


        Auto merge of #14907 - bholley:eliminate_consume, r=<try>

Give up on hoisting ElementData into the frame and eliminate the concept of consuming styles Servo PR for the work in https://bugzilla.mozilla.org/show_bug.cgi?id=1325734  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14907)

bors-servo · 2017-01-08T22:09:33Z

💔 Test failed - windows-msvc-dev

bholley · 2017-01-08T22:48:28Z

@bors-servo retry

bors-servo · 2017-01-08T22:48:31Z

⌛ Trying commit 9570ef3 with merge b6c8003...

bors-servo · 2017-01-08T23:34:40Z

💔 Test failed - windows-gnu-dev

bholley · 2017-01-09T01:40:27Z

LLVM ERROR: IO failure on output stream

@jdm Is this #14723? If so, what should I do about it?


        Bug 1325734 - Remove Servo Layout's dependency on the initial-ness of…

… the style. r=emilio


        Bug 1325734 - Parameterize the style traversal on TElement instead of…

… TNode. r=emilio This works around the issue described in rust-lang/rust#38917


        Bug 1325734 - Pass the thread-local context into should_traverse_chil…

…dren. r=emilio


        Bug 1325734 - Explicitly track whether we're performing the initial s…

…tyle. r=emilio


        Bug 1325734 - Simplify ElementData and eliminate the concept of consu…

…ming styles. r=emilio

bholley · 2017-01-09T19:53:47Z

Let's see if that weird LLVM error is gone before putting this in the queue.

@bors-servo try

bors-servo · 2017-01-09T19:53:51Z

⌛ Trying commit 3fcfc9c with merge c03e385...


        Auto merge of #14907 - bholley:eliminate_consume, r=<try>

Give up on hoisting ElementData into the frame and eliminate the concept of consuming styles Servo PR for the work in https://bugzilla.mozilla.org/show_bug.cgi?id=1325734  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14907)

emilio · 2017-01-09T20:05:39Z

The LLVM error has been seen in other PRs and went away retrying.

@bors-servo r+

bors-servo · 2017-01-09T20:05:40Z

📌 Commit 3fcfc9c has been approved by emilio

bholley · 2017-01-09T20:12:16Z

Awesome, thanks Emilio!

bholley · 2017-01-09T20:12:20Z

@bors-servo try-

bholley · 2017-01-09T20:12:32Z

@bors-servo r-

bholley · 2017-01-09T20:13:03Z

@bors-servo r=emilio

bors-servo · 2017-01-09T20:13:03Z

📌 Commit 3fcfc9c has been approved by emilio

Manishearth · 2017-01-09T20:15:20Z

@bors-servo try- retry r=emilio clean

bors-servo · 2017-01-09T20:15:21Z

💡 This pull request was already approved, no need to approve it again.

This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

bors-servo · 2017-01-09T20:15:22Z

📌 Commit 3fcfc9c has been approved by emilio

bholley · 2017-01-09T21:08:01Z

@bors-servo p=1

We'll want this in the next incubator merge.

bors-servo · 2017-01-10T01:26:51Z

⌛ Testing commit 3fcfc9c with merge 2a2a89b...


        Auto merge of #14907 - bholley:eliminate_consume, r=emilio

Give up on hoisting ElementData into the frame and eliminate the concept of consuming styles Servo PR for the work in https://bugzilla.mozilla.org/show_bug.cgi?id=1325734  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14907)

bors-servo · 2017-01-10T02:36:35Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev

highfive assigned pcwalton Jan 7, 2017

highfive added the S-awaiting-review label Jan 7, 2017

bholley unassigned pcwalton Jan 7, 2017

highfive added S-tests-failed and removed S-tests-failed labels Jan 7, 2017

bholley force-pushed the bholley:eliminate_consume branch from ffedd27 to 9570ef3 Jan 8, 2017

highfive added the S-tests-failed label Jan 8, 2017

bholley added 3 commits Jan 7, 2017

Bug 1325734 - Remove Servo Layout's dependency on the initial-ness of…

962a4a7

… the style. r=emilio

Bug 1325734 - Parameterize the style traversal on TElement instead of…

3060865

… TNode. r=emilio This works around the issue described in rust-lang/rust#38917

Bug 1325734 - Pass the thread-local context into should_traverse_chil…

92b9d70

…dren. r=emilio

bholley added 2 commits Jan 8, 2017

Bug 1325734 - Explicitly track whether we're performing the initial s…

4558efb

…tyle. r=emilio

Bug 1325734 - Simplify ElementData and eliminate the concept of consu…

Loading status checks…

3fcfc9c

…ming styles. r=emilio

bholley force-pushed the bholley:eliminate_consume branch from 9570ef3 to 3fcfc9c Jan 9, 2017

highfive removed the S-tests-failed label Jan 9, 2017

highfive assigned emilio Jan 9, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 9, 2017

bors-servo merged commit 3fcfc9c into servo:master Jan 10, 2017
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jan 10, 2017

servo / servo

Give up on hoisting ElementData into the frame and eliminate the concept of consuming styles #14907

Give up on hoisting ElementData into the frame and eliminate the concept of consuming styles #14907

bholley commented Jan 7, 2017 •

edited by larsbergstrom

highfive commented Jan 7, 2017

highfive commented Jan 7, 2017

bholley commented Jan 7, 2017

bors-servo commented Jan 7, 2017

bors-servo commented Jan 7, 2017

bholley commented Jan 7, 2017

bors-servo commented Jan 7, 2017

bors-servo commented Jan 7, 2017

bholley commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bholley commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bholley commented Jan 9, 2017

bholley commented Jan 9, 2017

bors-servo commented Jan 9, 2017

emilio commented Jan 9, 2017

bors-servo commented Jan 9, 2017

bholley commented Jan 9, 2017

bholley commented Jan 9, 2017

bholley commented Jan 9, 2017

bholley commented Jan 9, 2017

bors-servo commented Jan 9, 2017

Manishearth commented Jan 9, 2017

bors-servo commented Jan 9, 2017

bors-servo commented Jan 9, 2017

bholley commented Jan 9, 2017

bors-servo commented Jan 10, 2017

bors-servo commented Jan 10, 2017

servo / servo

Join GitHub today

Give up on hoisting ElementData into the frame and eliminate the concept of consuming styles #14907

Give up on hoisting ElementData into the frame and eliminate the concept of consuming styles #14907

Conversation

bholley commented Jan 7, 2017 • edited by larsbergstrom

highfive commented Jan 7, 2017

highfive commented Jan 7, 2017

bholley commented Jan 7, 2017

bors-servo commented Jan 7, 2017

bors-servo commented Jan 7, 2017

bholley commented Jan 7, 2017

bors-servo commented Jan 7, 2017

bors-servo commented Jan 7, 2017

bholley commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bholley commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bholley commented Jan 9, 2017

bholley commented Jan 9, 2017

bors-servo commented Jan 9, 2017

emilio commented Jan 9, 2017

bors-servo commented Jan 9, 2017

bholley commented Jan 9, 2017

bholley commented Jan 9, 2017

bholley commented Jan 9, 2017

bholley commented Jan 9, 2017

bors-servo commented Jan 9, 2017

Manishearth commented Jan 9, 2017

bors-servo commented Jan 9, 2017

bors-servo commented Jan 9, 2017

bholley commented Jan 9, 2017

bors-servo commented Jan 10, 2017

bors-servo commented Jan 10, 2017

bholley commented Jan 7, 2017 •

edited by larsbergstrom