Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd git author #14935
Merged
Add git author #14935
Conversation
highfive
commented
Jan 10, 2017
|
Heads up! This PR modifies the following files:
|
|
LGTM aside from 2 nits. |
etc/ci/upload_nightly.sh
Outdated
| @@ -52,7 +52,8 @@ update_brew() { | |||
| > "${tmp_dir}/Formula/servo-bin.rb" | |||
|
|
|||
| git -C "${tmp_dir}" add ./Formula/servo-bin.rb | |||
| git -C "${tmp_dir}" commit -m "Version bump: ${version}" | |||
| git -C "${tmp_dir}" commit --author="Tom Servo <servo@servo.org>" \ | |||
This comment has been minimized.
This comment has been minimized.
etc/ci/upload_nightly.sh
Outdated
| @@ -52,7 +52,8 @@ update_brew() { | |||
| > "${tmp_dir}/Formula/servo-bin.rb" | |||
|
|
|||
| git -C "${tmp_dir}" add ./Formula/servo-bin.rb | |||
| git -C "${tmp_dir}" commit -m "Version bump: ${version}" | |||
| git -C "${tmp_dir}" commit --author="Tom Servo <servo@servo.org>" \ | |||
| -m "Version bump: ${version}" | |||
This comment has been minimized.
This comment has been minimized.
|
Comments addressed. |
|
Thanks for the fix! I'm actually not sure how this was working before... |
|
|
|
@bors-servo: retry
|
bors-servo
added a commit
that referenced
this pull request
Jan 10, 2017
Add git author fix servo/saltfs#575 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14935) <!-- Reviewable:end -->
Merged
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 13, 2017
…ad, r=jdm Fix git author setting for brew upload <!-- Please describe your changes on the following line: --> The fix from #14935 wasn't quite right. cc @paulrouget --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix servo/saltfs#575 properly (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they should be tested by running the mac-nightly builder <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15005) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedJan 10, 2017
•
edited by larsbergstrom
fix servo/saltfs#575
This change is