Add aliases for geckolib for supported properties #14939

upsuper · 2017-01-10T10:44:57Z

This fixes ~7.5k failures in style system mochitests.

r? @Manishearth

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #__ (github issue number if applicable).

There are tests for these changes OR
These changes do not require tests because it is for geckolib only

This change is

highfive · 2017-01-10T10:45:00Z

Heads up! This PR modifies the following files:

@bholley: components/style/properties/longhand/inherited_text.mako.rs, components/style/properties/longhand/effects.mako.rs, components/style/properties/longhand/margin.mako.rs, components/style/properties/shorthand/box.mako.rs, components/style/properties/shorthand/border.mako.rs, components/style/properties/data.py, components/style/properties/longhand/background.mako.rs, components/style/properties/shorthand/column.mako.rs, components/style/properties/longhand/column.mako.rs, components/style/properties/shorthand/mask.mako.rs, components/style/properties/shorthand/position.mako.rs, components/style/properties/longhand/ui.mako.rs, components/style/properties/longhand/padding.mako.rs, components/style/properties/longhand/font.mako.rs, components/style/properties/longhand/position.mako.rs, components/style/properties/longhand/border.mako.rs, components/style/properties/longhand/svg.mako.rs, components/style/properties/longhand/box.mako.rs, components/style/properties/properties.mako.rs, components/style/properties/longhand/xul.mako.rs
@emilio: components/style/properties/longhand/inherited_text.mako.rs, components/style/properties/longhand/effects.mako.rs, components/style/properties/longhand/margin.mako.rs, components/style/properties/shorthand/box.mako.rs, components/style/properties/shorthand/border.mako.rs, components/style/properties/data.py, components/style/properties/longhand/background.mako.rs, components/style/properties/shorthand/column.mako.rs, components/style/properties/longhand/column.mako.rs, components/style/properties/shorthand/mask.mako.rs, components/style/properties/shorthand/position.mako.rs, components/style/properties/longhand/ui.mako.rs, components/style/properties/longhand/padding.mako.rs, components/style/properties/longhand/font.mako.rs, components/style/properties/longhand/position.mako.rs, components/style/properties/longhand/border.mako.rs, components/style/properties/longhand/svg.mako.rs, components/style/properties/longhand/box.mako.rs, components/style/properties/properties.mako.rs, components/style/properties/longhand/xul.mako.rs

highfive · 2017-01-10T10:45:02Z

Warning

These commits modify style code, but no tests are modified. Please consider adding a test!

emilio · 2017-01-10T10:50:51Z

components/style/properties/data.py

@@ -220,12 +230,19 @@ def new_style_struct(self, *args, **kwargs):
    def active_style_structs(self):
        return [s for s in self.style_structs if s.additional_methods or s.longhands]

+    def add_prefixed_aliases(self, property_data):
+        # FIXME Servo's DOM architecture doesn't support vendor-prefixed properties.


What do you mean by this? We should be able to treat them the same way while parsing, right?

See CSSStyleDeclaration.webidl, there are attributes for properties as their original form. For vendor-prefixed properties, that would be something like attribute DOMString -webkit-foo;. However, name starting with - is invalid in WebIDL.

FWIW, Gecko prepends _ to property names in WebIDL files. See CSS2Properties.webidl. There is probably some magic in the codegen to handle this.

Oh, ok, I see, I'll file an issue.

We probably need to auto-generate that webidl file eventually anyway.

Can you reference #14941 from that comment?

OK, will do tomorrow.

FWIW Gecko has a bug here where CSSSD can be indexed with webkit-foo without the preceding dash.

Also, for future reference we do not want moz or unspecced webkit prefixes in Servo unless absolutely necessary. Only prefixes from the compat spec (and change the spec if a property seems necessary). We may want to split this attribute into two or use ifs at the usage site when we start thinking about servo.

emilio · 2017-01-10T10:50:51Z

components/style/properties/data.py

@@ -135,7 +144,7 @@ def __init__(self, style_struct, name, spec=None, animatable=None, derived_from=

 class Shorthand(object):
    def __init__(self, name, sub_properties, spec=None, experimental=False, internal=False,
-                 allowed_in_keyframe_block=True, alias=None):
+                 allowed_in_keyframe_block=True, alias=None, prefixes=None):


I'd really like this to be called extra_prefixes instead of just prefixes, but don't worry if it's too much churn.

extra_prefixes makes sense to me. I can change it to that tomorrow.

bors-servo · 2017-01-10T11:52:16Z

☔ The latest upstream changes (presumably #14879) made this pull request unmergeable. Please resolve the merge conflicts.

emilio · 2017-01-10T14:05:03Z

You can pretty much r=me when the comments are addressed and this is rebased.

Manishearth

r=me with our comments addressed

Manishearth · 2017-01-10T16:31:51Z

components/style/properties/data.py

@@ -220,12 +230,19 @@ def new_style_struct(self, *args, **kwargs):
    def active_style_structs(self):
        return [s for s in self.style_structs if s.additional_methods or s.longhands]

+    def add_prefixed_aliases(self, property_data):
+        # FIXME Servo's DOM architecture doesn't support vendor-prefixed properties.


FWIW Gecko has a bug here where CSSSD can be indexed with webkit-foo without the preceding dash.

Manishearth · 2017-01-10T16:31:51Z

components/style/properties/data.py

@@ -220,12 +230,19 @@ def new_style_struct(self, *args, **kwargs):
    def active_style_structs(self):
        return [s for s in self.style_structs if s.additional_methods or s.longhands]

+    def add_prefixed_aliases(self, property_data):


nit: Probably just call it property to be consistent

Manishearth · 2017-01-10T16:31:51Z

components/style/properties/data.py

@@ -14,6 +14,14 @@
 ALL_SIZES = [(size, False) for size in PHYSICAL_SIZES] + [(size, True) for size in LOGICAL_SIZES]


+def maybe_moz_logical_alias(product, side, prop):


Please leave a comment here that inline-start and -end props can omit the inline.

The legacy moz-prefixed logical properties are only for inline axis. I guess this can be added to the comment.

Manishearth · 2017-01-10T16:31:51Z

components/style/properties/data.py

@@ -220,12 +230,19 @@ def new_style_struct(self, *args, **kwargs):
    def active_style_structs(self):
        return [s for s in self.style_structs if s.additional_methods or s.longhands]

+    def add_prefixed_aliases(self, property_data):
+        # FIXME Servo's DOM architecture doesn't support vendor-prefixed properties.


Also, for future reference we do not want moz or unspecced webkit prefixes in Servo unless absolutely necessary. Only prefixes from the compat spec (and change the spec if a property seems necessary). We may want to split this attribute into two or use ifs at the usage site when we start thinking about servo.

Manishearth · 2017-01-10T16:33:33Z

Should these mochitests still be relying on prefixes, btw? Sounds like too much effort to fix right now, but worth filing a bug for.

(A sweep through these might also help us identify tests which don't actually need to be mochitests and can be moved to csswg)

bholley · 2017-01-10T17:36:13Z

Are they "relying on prefixes", or just testing all the prefixes that we ship? If the latter, the issue is "should we be shipping these prefixes", which is a broader policy question (and generally a complicated one, owned by the web-compat team).


        Fix alias handling in properties.mako

upsuper · 2017-01-11T00:11:30Z

Right, those tests are just testing all the aliases Gecko currently ships.

Manishearth · 2017-01-11T00:13:24Z

@bors-servo delegate+

bors-servo · 2017-01-11T00:13:25Z

✌️ @upsuper can now approve this pull request


        Add prefixes parameter for properties


        Add gecko leagcy logical properties aliases


        Add other property aliases

upsuper · 2017-01-11T00:18:55Z

@bors-servo r=emilio,Manishearth

bors-servo · 2017-01-11T00:18:56Z

📌 Commit 8a8ef48 has been approved by emilio,Manishearth

bors-servo · 2017-01-11T00:19:00Z

⌛ Testing commit 8a8ef48 with merge 04a3242...


        Auto merge of #14939 - upsuper:add-aliases, r=emilio,Manishearth

@Manishearth

Add aliases for geckolib for supported properties  This fixes ~7.5k failures in style system mochitests. r? @Manishearth ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [x] These changes do not require tests because it is for geckolib only   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14939)

bors-servo · 2017-01-11T01:13:08Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev

highfive assigned Manishearth Jan 10, 2017

highfive added the S-awaiting-review label Jan 10, 2017

emilio reviewed Jan 10, 2017

View changes

highfive added the S-needs-rebase label Jan 10, 2017

Manishearth approved these changes Jan 10, 2017

View changes

Fix alias handling in properties.mako

8af8168

upsuper added 3 commits Jan 10, 2017

Add prefixes parameter for properties

e494a0f

Add gecko leagcy logical properties aliases

2f2044e

Add other property aliases

Loading status checks…

8a8ef48

upsuper force-pushed the upsuper-forks:add-aliases branch from f533c50 to 8a8ef48 Jan 11, 2017

highfive assigned emilio and unassigned Manishearth Jan 11, 2017

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Jan 11, 2017

bors-servo merged commit 8a8ef48 into servo:master Jan 11, 2017
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jan 11, 2017

upsuper deleted the upsuper-forks:add-aliases branch Jan 11, 2017

upsuper mentioned this pull request Jan 30, 2017

-moz-border-{start,end} and -moz-border-{start,end}-width are unavailable #15297

Closed

servo / servo

Add aliases for geckolib for supported properties #14939

Add aliases for geckolib for supported properties #14939

upsuper commented Jan 10, 2017 •

edited by larsbergstrom

highfive commented Jan 10, 2017

highfive commented Jan 10, 2017

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors-servo commented Jan 10, 2017

emilio commented Jan 10, 2017

Manishearth left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Manishearth commented Jan 10, 2017 •

edited

bholley commented Jan 10, 2017

upsuper commented Jan 11, 2017

Manishearth commented Jan 11, 2017

bors-servo commented Jan 11, 2017

upsuper commented Jan 11, 2017

bors-servo commented Jan 11, 2017

bors-servo commented Jan 11, 2017

bors-servo commented Jan 11, 2017

		@@ -14,6 +14,14 @@
		ALL_SIZES = [(size, False) for size in PHYSICAL_SIZES] + [(size, True) for size in LOGICAL_SIZES]


		def maybe_moz_logical_alias(product, side, prop):

servo / servo

Join GitHub today

Add aliases for geckolib for supported properties #14939

Add aliases for geckolib for supported properties #14939

Conversation

upsuper commented Jan 10, 2017 • edited by larsbergstrom

highfive commented Jan 10, 2017

highfive commented Jan 10, 2017

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors-servo commented Jan 10, 2017

emilio commented Jan 10, 2017

Manishearth left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Manishearth commented Jan 10, 2017 • edited

bholley commented Jan 10, 2017

upsuper commented Jan 11, 2017

Manishearth commented Jan 11, 2017

bors-servo commented Jan 11, 2017

upsuper commented Jan 11, 2017

bors-servo commented Jan 11, 2017

bors-servo commented Jan 11, 2017

bors-servo commented Jan 11, 2017

upsuper commented Jan 10, 2017 •

edited by larsbergstrom

Manishearth commented Jan 10, 2017 •

edited