Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git author setting for brew upload #15005

Merged
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Set git user info for Homebrew committing

The `git commit` command wants to set both an author and a committer.
The `--author` flag only sets the author,
leaving git without a value for the committer,
causing git to attempt to autodiscover that value.

To work around it, use the `-c` git flag to temporarily set the relevant
config variables for the scope of the command.
  • Loading branch information
aneeshusa committed Jan 13, 2017
commit 90735661fe0b8758105bae0a0e91fb224540415a
@@ -52,8 +52,10 @@ update_brew() {
> "${tmp_dir}/Formula/servo-bin.rb"

git -C "${tmp_dir}" add ./Formula/servo-bin.rb
git -C "${tmp_dir}" commit \
--author="Tom Servo <servo@servo.org>" \
git -C "${tmp_dir}" \
-c user.name="Tom Servo" \
-c user.email="servo@servo.org" \
commit \
--message="Version bump: ${version}"

git -C "${tmp_dir}" push -qf \
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.