Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regex. #15042

Merged
merged 1 commit into from Jan 16, 2017
Merged

Update regex. #15042

merged 1 commit into from Jan 16, 2017

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 16, 2017 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Jan 16, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml
  • @jgraham: components/webdriver_server/lib.rs, components/webdriver_server/Cargo.toml
  • @emilio: components/style/Cargo.toml, ports/geckolib/Cargo.toml
  • @fitzgen: components/script/Cargo.toml, components/profile/mem.rs, components/profile/Cargo.toml
  • @KiChjang: components/script/Cargo.toml
  • @asajeffrey: components/webdriver_server/lib.rs, components/webdriver_server/Cargo.toml
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jan 16, 2017

Hold off on landing for a bit; there was a bit of a mess-up with the webdriver versioning that I'd like to get fixed first.
@Ms2ger Ms2ger assigned Ms2ger and unassigned cbrewster Jan 16, 2017
@jgraham
Copy link
Contributor

jgraham commented Jan 16, 2017

The webdriver problem [1] should now be "fixed"; 0.18.1 is yanked, 0.19.0 is published.

[1] c.f. https://twitter.com/nokusu/status/788285254322774016
@Ms2ger
Update regex.
Loading status checks…
a1d478f
@Ms2ger Ms2ger force-pushed the update-regex branch from 38c7056 to a1d478f Jan 16, 2017
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jan 16, 2017

Good to go now.
@Ms2ger Ms2ger removed their assignment Jan 16, 2017
@jdm
Copy link
Member

jdm commented Jan 16, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2017

📌 Commit a1d478f has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2017

⌛ Testing commit a1d478f with merge bb540ca...
bors-servo added a commit that referenced this pull request Jan 16, 2017
@bors-servo
Auto merge of #15042 - servo:update-regex, r=jdm
Loading status checks…
bb540ca 
Update regex.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15042)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
@bors-servo bors-servo merged commit a1d478f into master Jan 16, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jan 16, 2017
Merged
@Ms2ger Ms2ger deleted the update-regex branch Jan 16, 2017
@upsuper upsuper mentioned this pull request Jan 17, 2017
Closed
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @highfive @jgraham @jdm @bors-servo @cbrewster
You can’t perform that action at this time.