Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency on the num crate. #15044

Merged
merged 1 commit into from Jan 16, 2017
Merged

Remove the dependency on the num crate. #15044

merged 1 commit into from Jan 16, 2017

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 16, 2017

This change is Reviewable

@jdm
Copy link
Member

jdm commented Jan 16, 2017

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jan 16, 2017

@bors-servo: r=jdm

@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2017

📌 Commit f911023 has been approved by jdm

@highfive highfive assigned jdm and unassigned glennw Jan 16, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2017

The latest upstream changes (presumably #15042) made this pull request unmergeable. Please resolve the merge conflicts.

@Ms2ger Ms2ger force-pushed the remove-num branch from f911023 to c06f6eb Jan 16, 2017
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jan 16, 2017

@bors-servo: r=jdm

@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2017

📌 Commit c06f6eb has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2017

Testing commit c06f6eb with merge 7a4b66f...

bors-servo added a commit that referenced this pull request Jan 16, 2017
Remove the dependency on the num crate.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15044)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2017

💔 Test failed - linux-rel-wpt

@jdm
Copy link
Member

jdm commented Jan 16, 2017

@bors-servo: retry

  • every test timed out??
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2017

Testing commit c06f6eb with merge 2fa4df8...

bors-servo added a commit that referenced this pull request Jan 16, 2017
Remove the dependency on the num crate.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15044)
<!-- Reviewable:end -->
@bors-servo bors-servo merged commit c06f6eb into master Jan 16, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the remove-num branch Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.