Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some things related to script loading #15072

Merged
merged 5 commits into from Jan 18, 2017
Merged

Refactor some things related to script loading #15072

merged 5 commits into from Jan 18, 2017

Conversation

@nox
Copy link
Member

nox commented Jan 17, 2017 •
edited by larsbergstrom

This change is Reviewable
@nox
Kill HTMLScriptElement::ready_to_be_parser_executed
5756f2f
@highfive
Copy link

highfive commented Jan 17, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/document.rs, components/script/dom/htmlscriptelement.rs
  • @KiChjang: components/script/dom/document.rs, components/script/dom/htmlscriptelement.rs
@highfive
Copy link

highfive commented Jan 17, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
nox added 2 commits Jan 15, 2017
@nox
Reorder some Document methods to put them together
a60bbc8
@nox
Remove an obsolete reflow
d297269
@nox nox force-pushed the nox:load-fixes branch from 292aed0 to af24a5a Jan 17, 2017
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 17, 2017

r=me on the first three commits, not entirely convinced about the fourth yet.
@nox nox force-pushed the nox:load-fixes branch from af24a5a to ce394d3 Jan 17, 2017
nox added 2 commits Jan 17, 2017
@nox
Remove ScriptThread::parsing_complete
70ed3e7
@nox
Reorder some steps in ServoParser::finish
Loading status checks…
44fd53f
@nox nox force-pushed the nox:load-fixes branch from ce394d3 to 44fd53f Jan 17, 2017
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 17, 2017

r=me on the first four, would like @jdm's thoughts on the fifth (sorry!)
@nox
Copy link
Member Author

nox commented Jan 17, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2017

⌛ Trying commit 44fd53f with merge edc5165...
bors-servo added a commit that referenced this pull request Jan 17, 2017
@bors-servo
Auto merge of #15072 - nox:load-fixes, r=<try>
Loading status checks…
edc5165 
Refactor some things related to script loading

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15072)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
@jdm
Copy link
Member

jdm commented Jan 17, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2017

📌 Commit 44fd53f has been approved by jdm
@highfive highfive assigned jdm and unassigned KiChjang Jan 17, 2017
@nox
Copy link
Member Author

nox commented Jan 17, 2017

@bors-servo retry

Travis failed for some unknown reason.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2017

⌛ Testing commit 44fd53f with merge 0ba7f1a...
bors-servo added a commit that referenced this pull request Jan 17, 2017
@bors-servo
Auto merge of #15072 - nox:load-fixes, r=jdm
Loading status checks…
0ba7f1a 
Refactor some things related to script loading

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15072)
<!-- Reviewable:end -->
@jdm
Copy link
Member

jdm commented Jan 17, 2017

That's #15076.
@bors-servo: try- r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2017

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2017

📌 Commit 44fd53f has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2017

💥 Test timed out
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 18, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2017

⌛ Testing commit 44fd53f with merge 80c6383...
bors-servo added a commit that referenced this pull request Jan 18, 2017
@bors-servo
Auto merge of #15072 - nox:load-fixes, r=jdm
Loading status checks…
80c6383 
Refactor some things related to script loading

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15072)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
@bors-servo bors-servo merged commit 44fd53f into servo:master Jan 18, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jan 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @Ms2ger @bors-servo @jdm @KiChjang
You can’t perform that action at this time.