Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate cert-generator and certs #15106
Conversation
|
JSON of the certificate list: https://gist.github.com/Manishearth/125b162c40f10cdb2800acb292eb9119 I wonder why LetsEncrypt isn't in there. |
|
@Manishearth i'll review once we figure out why lets encrypt isn't there :) |
|
What's the status on this? |
|
We don't know why LE isn't there. |
|
I guess landing this is strictly better? The old code doesn't work at all. |
|
Have we talked to anybody from the Gecko team who would know? |
|
I think we did, but not much, and there wasn't a conclusion. We should look at this again. |
|
Did we look at this again? |
|
No |
|
@Manishearth Could you? |
|
I don't care enough at this point. This can be merged as-is with a disclaimer that it doesn't get all certs. |
AFAIK LetsEncrypt certificates are cross-signed by IdenTrust ("DST Root CA X3" Root CA), which is listed in the json |
|
We ran it on a Firefox with LE in the trust store and it didn't work. |
|
Let me try again. |
|
I had a second look, looks like LE isn't in the trust store. Could swear it was. Updated with nightly cert store. See https://gist.github.com/Manishearth/84049982d60d6579bfc0eaf5961300d4 Anyway, r? @avadacatavra |
|
@bors-servo r+ |
|
|
Update cert-generator and certs r? @avadacatavra <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15106) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
|
|
Manishearth commentedJan 19, 2017
•
edited by larsbergstrom
r? @avadacatavra
This change is