Update WR (radial gradients, generate_frame API, mac subpixel improvements, ANGLE shader support). #15111

glennw · 2017-01-19T13:58:26Z

This change is

glennw · 2017-01-19T14:00:38Z

bors-servo · 2017-01-19T14:00:43Z

⌛ Trying commit 6b3b082 with merge 315da6b...


        Auto merge of #15111 - glennw:wr-update-generate, r=<try>

Update WR (radial gradients, generate_frame API, mac subpixel improvements, ANGLE shader support).  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15111)

Ms2ger · 2017-01-19T14:01:36Z

./Cargo.lock:1: duplicate versions for package `core-graphics`
	The following packages depend on version 0.4.2 from 'crates.io':
		azure
		cocoa
		core-text
		gfx
		servo-glutin
	The following packages depend on version 0.5.0 from 'crates.io':
		webrender
		webrender_traits

glennw · 2017-01-19T14:04:19Z

@Ms2ger Ugh - I guess that means this can't land until those other packages are updated to 0.5.0? That's unfortunate timing :|

bors-servo · 2017-01-19T14:06:35Z

💔 Test failed - mac-dev-unit

Manishearth · 2017-01-19T16:11:29Z

r=me when conflcits are resolved

jdm · 2017-01-19T20:05:30Z

All other packages are published. This should be ready to go.

Manishearth · 2017-01-19T20:06:45Z

Ooh radial gradiants, finally 😀

glennw · 2017-01-19T20:14:38Z

r? @jdm or anyone.

jdm · 2017-01-19T20:16:06Z

@bors-servo: r+

bors-servo · 2017-01-19T20:16:07Z

📌 Commit e216cfa has been approved by jdm

bors-servo · 2017-01-19T20:57:57Z

⌛ Testing commit e216cfa with merge a81a712...


        Auto merge of #15111 - glennw:wr-update-generate, r=jdm

Update WR (radial gradients, generate_frame API, mac subpixel improvements, ANGLE shader support).  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15111)

bors-servo · 2017-01-19T22:10:31Z

💔 Test failed - linux-rel-css

glennw · 2017-01-19T22:49:01Z

@bors-servo try

glennw · 2017-01-20T13:50:44Z

@bors-servo r- try clean

Ms2ger · 2017-01-20T14:19:27Z

@bors-servo try- clean r=jdm


        Auto merge of #15111 - glennw:wr-update-generate, r=<try>

Update WR (radial gradients, generate_frame API, mac subpixel improvements, ANGLE shader support).  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15111)

bors-servo · 2017-01-30T21:05:07Z

☔ The latest upstream changes (presumably #15302) made this pull request unmergeable. Please resolve the merge conflicts.

glennw · 2017-01-30T21:25:30Z

@bors-servo try

bors-servo · 2017-01-30T21:25:34Z

⌛ Trying commit 07b0d7e with merge ed0e5e1...


        Auto merge of #15111 - glennw:wr-update-generate, r=<try>

Update WR (radial gradients, generate_frame API, mac subpixel improvements, ANGLE shader support).  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15111)

glennw · 2017-01-31T00:40:32Z

@bors-servo try

bors-servo · 2017-01-31T00:40:35Z

⌛ Trying commit 97589de with merge d73f364...


        Auto merge of #15111 - glennw:wr-update-generate, r=<try>

Update WR (radial gradients, generate_frame API, mac subpixel improvements, ANGLE shader support).  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15111)

bors-servo · 2017-01-31T02:15:04Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev

glennw · 2017-01-31T02:16:34Z

r? @pcwalton or anyone

pcwalton · 2017-01-31T19:38:11Z

components/net/image_cache_thread.rs

@@ -33,6 +33,25 @@ use webrender_traits;
 /// MAYBE(Yoric):
 ///     * For faster lookups, it might be useful to store the LoadKey in the DOM once we have performed a first load.

+// TODO(gw): This is a port of the old is_image_opaque code from WR.


Add a comment saying that this is slow and needs SIMD


        Update WR (radial gradients, subpixel positioning, tiling changes).

pcwalton · 2017-01-31T19:49:15Z

@bors-servo: r+

bors-servo · 2017-01-31T19:49:15Z

📌 Commit 4cbefe8 has been approved by pcwalton

bors-servo · 2017-01-31T19:49:19Z

⌛ Testing commit 4cbefe8 with merge 8421ae6...


        Auto merge of #15111 - glennw:wr-update-generate, r=pcwalton

Update WR (radial gradients, generate_frame API, mac subpixel improvements, ANGLE shader support).  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15111)

bors-servo · 2017-01-31T20:43:49Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev

highfive assigned Manishearth Jan 19, 2017

highfive added the S-awaiting-review label Jan 19, 2017

highfive added the S-tests-failed label Jan 19, 2017

glennw mentioned this pull request Jan 19, 2017

Gray screen and GL error on ARM Linux #15110

Closed

glennw force-pushed the glennw:wr-update-generate branch from 6b3b082 to e216cfa Jan 19, 2017

highfive removed the S-tests-failed label Jan 19, 2017

highfive assigned jdm and unassigned Manishearth Jan 19, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 19, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 19, 2017

highfive added the S-needs-rebase label Jan 30, 2017

glennw force-pushed the glennw:wr-update-generate branch from 07b023e to 07b0d7e Jan 30, 2017

glennw force-pushed the glennw:wr-update-generate branch from 07b0d7e to 97589de Jan 31, 2017

highfive assigned pcwalton and unassigned jdm Jan 31, 2017

jdm removed S-blocked-on-external S-needs-rebase labels Jan 31, 2017

pcwalton reviewed Jan 31, 2017

View changes

Update WR (radial gradients, subpixel positioning, tiling changes).

Loading status checks…

4cbefe8

glennw force-pushed the glennw:wr-update-generate branch from 97589de to 4cbefe8 Jan 31, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 31, 2017

bors-servo merged commit 4cbefe8 into servo:master Jan 31, 2017
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jan 31, 2017

glennw deleted the glennw:wr-update-generate branch Jan 31, 2017

servo / servo

Update WR (radial gradients, generate_frame API, mac subpixel improvements, ANGLE shader support). #15111

Update WR (radial gradients, generate_frame API, mac subpixel improvements, ANGLE shader support). #15111

glennw commented Jan 19, 2017 •

edited by larsbergstrom

glennw commented Jan 19, 2017

bors-servo commented Jan 19, 2017

Ms2ger commented Jan 19, 2017

glennw commented Jan 19, 2017

bors-servo commented Jan 19, 2017

Manishearth commented Jan 19, 2017

jdm commented Jan 19, 2017

Manishearth commented Jan 19, 2017

glennw commented Jan 19, 2017

jdm commented Jan 19, 2017

bors-servo commented Jan 19, 2017

bors-servo commented Jan 19, 2017

bors-servo commented Jan 19, 2017

glennw commented Jan 19, 2017

glennw commented Jan 20, 2017

Ms2ger commented Jan 20, 2017

bors-servo commented Jan 30, 2017

glennw commented Jan 30, 2017

bors-servo commented Jan 30, 2017

glennw commented Jan 31, 2017

bors-servo commented Jan 31, 2017

bors-servo commented Jan 31, 2017

glennw commented Jan 31, 2017

This comment has been minimized.

This comment has been minimized.

pcwalton commented Jan 31, 2017

bors-servo commented Jan 31, 2017

bors-servo commented Jan 31, 2017

bors-servo commented Jan 31, 2017

servo / servo

Join GitHub today

Update WR (radial gradients, generate_frame API, mac subpixel improvements, ANGLE shader support). #15111

Update WR (radial gradients, generate_frame API, mac subpixel improvements, ANGLE shader support). #15111

Conversation

glennw commented Jan 19, 2017 • edited by larsbergstrom

glennw commented Jan 19, 2017

bors-servo commented Jan 19, 2017

Ms2ger commented Jan 19, 2017

glennw commented Jan 19, 2017

bors-servo commented Jan 19, 2017

Manishearth commented Jan 19, 2017

jdm commented Jan 19, 2017

Manishearth commented Jan 19, 2017

glennw commented Jan 19, 2017

jdm commented Jan 19, 2017

bors-servo commented Jan 19, 2017

bors-servo commented Jan 19, 2017

bors-servo commented Jan 19, 2017

glennw commented Jan 19, 2017

glennw commented Jan 20, 2017

Ms2ger commented Jan 20, 2017

bors-servo commented Jan 30, 2017

glennw commented Jan 30, 2017

bors-servo commented Jan 30, 2017

glennw commented Jan 31, 2017

bors-servo commented Jan 31, 2017

bors-servo commented Jan 31, 2017

glennw commented Jan 31, 2017

This comment has been minimized.

pcwalton Jan 31, 2017

This comment has been minimized.

glennw Jan 31, 2017

pcwalton commented Jan 31, 2017

bors-servo commented Jan 31, 2017

bors-servo commented Jan 31, 2017

bors-servo commented Jan 31, 2017

glennw commented Jan 19, 2017 •

edited by larsbergstrom