Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dictionaries in unions. #15125

Merged
merged 1 commit into from Jan 20, 2017
Merged

Support dictionaries in unions. #15125

merged 1 commit into from Jan 20, 2017

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 20, 2017

Fixes #11612.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Jan 20, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/bindings/codegen/CodegenRust.py
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py
@highfive

This comment has been minimized.

Copy link

highfive commented Jan 20, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
Fixes #11612.
@Ms2ger Ms2ger force-pushed the unions-dictionaries branch from f7f52a2 to 6a6f339 Jan 20, 2017
@nox

This comment has been minimized.

Copy link
Member

nox commented Jan 20, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 20, 2017

📌 Commit 6a6f339 has been approved by nox

@highfive highfive assigned nox and unassigned Manishearth Jan 20, 2017
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 20, 2017

⌛️ Testing commit 6a6f339 with merge be3f358...

bors-servo added a commit that referenced this pull request Jan 20, 2017
Support dictionaries in unions.

Fixes #11612.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15125)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

@bors-servo bors-servo merged commit 6a6f339 into master Jan 20, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the unions-dictionaries branch Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.