Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert "Remove -w flag now that WebRender is always used" #15158
Conversation
highfive
commented
Jan 23, 2017
|
Heads up! This PR modifies the following files:
|
|
@bors-servo: r+ |
|
|
|
@bors-servo p=10 |
bors-servo
added a commit
that referenced
this pull request
Jan 23, 2017
Revert "Remove -w flag now that WebRender is always used" This reverts commit b94b58f. The wptrunner changes are not quite right and cause Python exceptions inside the test haness. This reverts #15064. See build.servo.org/builders/linux-rel-css/builds/2005/steps/test/logs/stdio for an example log with the error; not sure why Homu didn't catch this in the actual PR. cc @Ms2ger If possible I'd like help on a fixed version of the patch; otherwise I'll send in a revert to the wptrunner repo as well. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15158) <!-- Reviewable:end -->
|
|
Maybe related to #15155? |
|
or #15129 |
|
@cynicaldevil confirms the test failure was caused by #15129, so we should probably revert that at the same time, along with #15155 which depends on it. |
|
@bors-servo retry
|
|
|
|
|
|
I resubmitted this as part of #15164. |
|
I only see 3 failures on buildbot:
@cynicaldevil which test failure was caused by #15129? |
|
Oops, didn't see your update. |
bors-servo
added a commit
that referenced
this pull request
Jan 24, 2017
Revert several changes that broke tests This is based on #15158 by @aneeshusa, with additional reverts. This reverts #15064, which is causing many tests not to run, and #15129 and #15155 which landed while tests were not running and may have caused some new failures in iframe tests. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15164) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Jan 24, 2017
Revert several changes that broke tests This is based on #15158 by @aneeshusa, with additional reverts. This reverts #15064, which is causing many tests not to run, and #15129 and #15155 which landed while tests were not running and may have caused some new failures in iframe tests. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15164) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Jan 24, 2017
Revert several changes that broke tests This is based on #15158 by @aneeshusa, with additional reverts. This reverts #15064, which is causing many tests not to run, and #15129 and #15155 which landed while tests were not running and may have caused some new failures in iframe tests. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15164) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedJan 23, 2017
•
edited by larsbergstrom
This reverts commit b94b58f.
The wptrunner changes are not quite right and cause Python exceptions
inside the test haness.
This reverts #15064. See build.servo.org/builders/linux-rel-css/builds/2005/steps/test/logs/stdio for an example log with the error; not sure why Homu didn't catch this in the actual PR.
cc @Ms2ger If possible I'd like help on a fixed version of the patch; otherwise I'll send in a revert to the wptrunner repo as well.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is