Revert several changes that broke tests #15164

mbrubeck · 2017-01-24T00:52:03Z

This is based on #15158 by @aneeshusa, with additional reverts.

This reverts #15064, which is causing many tests not to run, and #15129 and #15155 which landed while tests were not running and may have caused some new failures in iframe tests.

This change is


        Revert "Remove -w flag now that WebRender is always used"

This reverts commit b94b58f. The wptrunner changes are not quite right and causes Python exceptions inside the test haness.


        Revert "constellation: Cleanup the frame size handler."

This reverts commit 79ef206.


        Revert "frame-resize refactor"

This reverts commit bca565a.

highfive · 2017-01-24T00:52:07Z

Heads up! This PR modifies the following files:

@asajeffrey: components/constellation/constellation.rs
@jgraham: tests/wpt/harness/wptrunner/webdriver_server.py, tests/wpt/harness/wptrunner/browsers/servo.py, tests/wpt/harness/wptrunner/wptcommandline.py, tests/wpt/harness/wptrunner/executors/executorservo.py, tests/wpt/harness/wptrunner/browsers/servodriver.py
@KiChjang: components/script_traits/lib.rs, components/script_traits/lib.rs, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs
@fitzgen: components/script_traits/lib.rs, components/script_traits/lib.rs, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs
@emilio: components/layout/display_list_builder.rs

mbrubeck · 2017-01-24T00:52:49Z

@bors-servo p=10

glennw · 2017-01-24T00:54:35Z

@bors-servo r+

bors-servo · 2017-01-24T00:54:36Z

📌 Commit 6ead395 has been approved by glennw

Manishearth · 2017-01-24T00:55:05Z

@bors-servo r+

bors-servo · 2017-01-24T00:55:06Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #15142

bors-servo · 2017-01-24T00:55:06Z

📌 Commit 6ead395 has been approved by Manishearth

emilio · 2017-01-24T01:34:20Z

@bors-servo r- try- clear

emilio · 2017-01-24T01:34:24Z

@bors-servo r+

bors-servo · 2017-01-24T01:34:24Z

📌 Commit 6ead395 has been approved by emilio

emilio · 2017-01-24T01:34:32Z

@bors-servo force p=1000

bors-servo · 2017-01-24T01:39:12Z

⌛ Testing commit 6ead395 with merge 240d647...


        Auto merge of #15164 - mbrubeck:revert, r=emilio

@aneeshusa

Revert several changes that broke tests This is based on #15158 by @aneeshusa, with additional reverts. This reverts #15064, which is causing many tests not to run, and #15129 and #15155 which landed while tests were not running and may have caused some new failures in iframe tests.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15164)

bors-servo · 2017-01-24T02:06:23Z

💔 Test failed - windows-msvc-dev

Ms2ger · 2017-01-24T15:13:50Z

@bors-servo retry

bors-servo · 2017-01-24T16:58:25Z

⌛ Testing commit 6ead395 with merge f4311a1...


        Auto merge of #15164 - mbrubeck:revert, r=emilio

@aneeshusa

Revert several changes that broke tests This is based on #15158 by @aneeshusa, with additional reverts. This reverts #15064, which is causing many tests not to run, and #15129 and #15155 which landed while tests were not running and may have caused some new failures in iframe tests.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15164)

bors-servo · 2017-01-24T17:40:05Z

💔 Test failed - linux-rel-css

emilio · 2017-01-24T17:55:26Z

@bors-servo retry

/css21_dev/html4/bidi-008b.htm, seems intermittent, will file now (#15182)

bors-servo · 2017-01-24T19:14:30Z

⌛ Testing commit 6ead395 with merge 185759f...


        Auto merge of #15164 - mbrubeck:revert, r=emilio

@aneeshusa

Revert several changes that broke tests This is based on #15158 by @aneeshusa, with additional reverts. This reverts #15064, which is causing many tests not to run, and #15129 and #15155 which landed while tests were not running and may have caused some new failures in iframe tests.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15164)

bors-servo · 2017-01-24T20:06:31Z

💔 Test failed - linux-rel-wpt

SimonSapin · 2017-01-24T20:07:54Z

  ▶ CRASH [expected OK] /encoding/textdecoder-labels.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  │ 3.3 (Core Profile) Mesa 12.0.1
  │ Stack trace for thread "ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(1) }"
  │ stack backtrace:
  │    0:     0x7f5ed17959ad - backtrace::backtrace::trace::h3daaf829744ddab9
  │    1:     0x7f5ed17960a2 - backtrace::capture::Backtrace::new::hd6fb6e83f9059b0d
  │    2:     0x7f5ecff7b1e4 - servo::install_crash_handler::handler::hb60740328a53f0c4
  │    3:     0x7f5ed11c38e3 - AsmJSFaultHandler
  │                         at /home/servo/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/7cd72d8/mozjs/js/src/asmjs/WasmSignalHandlers.cpp:1171
  │    4:     0x7f5ecde5132f - <unknown>
  │    5:     0x7f5ecfbbfffd - <unknown>
  │ Stack trace for thread "ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(1) }"
  │ stack backtrace:
  │    0:     0x7f5ed17959ad - backtrace::backtrace::trace::h3daaf829744ddab9
  │    1:     0x7f5ed17960a2 - backtrace::capture::Backtrace::new::hd6fb6e83f9059b0d
  │    2:     0x7f5ecff7b1e4 - servo::install_crash_handler::handler::hb60740328a53f0c4
  │    3:     0x7f5ecd89ccaf - <unknown>
  │    4:     0x7f5ecff7b26f - servo::install_crash_handler::handler::hb60740328a53f0c4
  │    5:     0x7f5ed11c38e3 - AsmJSFaultHandler
  │                         at /home/servo/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/7cd72d8/mozjs/js/src/asmjs/WasmSignalHandlers.cpp:1171
  │    6:     0x7f5ecde5132f - <unknown>
  └    7:     0x7f5ecfbbfffd - <unknown>

jdm · 2017-01-24T20:10:22Z

@bors-servo: retry

#15161

KiChjang · 2017-01-24T20:16:14Z

@bors-servo force

mbrubeck · 2017-01-24T20:17:11Z

@bors-servo force

bors-servo · 2017-01-24T20:18:01Z

⚡ Previous build results for android, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only arm32, arm64, linux-rel-wpt, mac-rel-css, windows-gnu-dev...

bors-servo · 2017-01-24T21:12:36Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev


        Auto merge of #15181 - jdm:wptfail, r=SimonSapin

Make test-wpt-failure smoketest work again. Having this testsuite working would have avoided the issue caused by #15064. This will need to wait until after #15164 is merged, because it picks up the failure that currently exists on master.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15181)

aneeshusa and others added 3 commits Jan 23, 2017

Revert "Remove -w flag now that WebRender is always used"

7595a90

This reverts commit b94b58f. The wptrunner changes are not quite right and causes Python exceptions inside the test haness.

Revert "constellation: Cleanup the frame size handler."

58e8ae8

This reverts commit 79ef206.

Revert "frame-resize refactor"

Loading status checks…

6ead395

This reverts commit bca565a.

highfive assigned Manishearth Jan 24, 2017

highfive added the S-awaiting-review label Jan 24, 2017

highfive assigned glennw and unassigned Manishearth Jan 24, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 24, 2017

highfive assigned Manishearth and unassigned glennw Jan 24, 2017

mbrubeck mentioned this pull request Jan 24, 2017

Revert "Remove -w flag now that WebRender is always used" #15158

Closed

0 of 5 tasks complete

emilio mentioned this pull request Jan 24, 2017

style: Expose the traversal kind to the style system. #15160

Merged

highfive assigned emilio and unassigned Manishearth Jan 24, 2017

highfive removed the S-awaiting-merge label Jan 24, 2017

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 24, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 24, 2017

jdm mentioned this pull request Jan 24, 2017

Make test-wpt-failure smoketest work again. #15181

Merged

glennw mentioned this pull request Jan 24, 2017

Remove pipeline_size_changed from RenderNotifier and update toml servo/webrender#772

Merged

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 24, 2017

jdm mentioned this pull request Jan 24, 2017

Fix parsing and serialization of font-family #15183

Merged

4 of 5 tasks complete

canova mentioned this pull request Jan 24, 2017

Fix serialization of CalcLengthOrPercentage #15178

Merged

4 of 5 tasks complete

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 24, 2017

bors-servo merged commit 6ead395 into servo:master Jan 24, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

jdm mentioned this pull request Jan 24, 2017

Figure out if Servo can just communicate iframe resizes to itself instead of relying on WebRender #14682

Closed

mbrubeck deleted the mbrubeck:revert branch May 2, 2017

servo / servo

Revert several changes that broke tests #15164

Revert several changes that broke tests #15164

mbrubeck commented Jan 24, 2017 •

edited by larsbergstrom

highfive commented Jan 24, 2017

mbrubeck commented Jan 24, 2017

glennw commented Jan 24, 2017

bors-servo commented Jan 24, 2017

Manishearth commented Jan 24, 2017

bors-servo commented Jan 24, 2017

bors-servo commented Jan 24, 2017

emilio commented Jan 24, 2017

emilio commented Jan 24, 2017

bors-servo commented Jan 24, 2017

emilio commented Jan 24, 2017 •

edited

bors-servo commented Jan 24, 2017

bors-servo commented Jan 24, 2017

Ms2ger commented Jan 24, 2017

bors-servo commented Jan 24, 2017

bors-servo commented Jan 24, 2017

emilio commented Jan 24, 2017 •

edited by jdm

bors-servo commented Jan 24, 2017

bors-servo commented Jan 24, 2017

SimonSapin commented Jan 24, 2017

jdm commented Jan 24, 2017

KiChjang commented Jan 24, 2017

mbrubeck commented Jan 24, 2017

bors-servo commented Jan 24, 2017

bors-servo commented Jan 24, 2017

servo / servo

Join GitHub today

Revert several changes that broke tests #15164

Revert several changes that broke tests #15164

Conversation

mbrubeck commented Jan 24, 2017 • edited by larsbergstrom

highfive commented Jan 24, 2017

mbrubeck commented Jan 24, 2017

glennw commented Jan 24, 2017

bors-servo commented Jan 24, 2017

Manishearth commented Jan 24, 2017

bors-servo commented Jan 24, 2017

bors-servo commented Jan 24, 2017

emilio commented Jan 24, 2017

emilio commented Jan 24, 2017

bors-servo commented Jan 24, 2017

emilio commented Jan 24, 2017 • edited

bors-servo commented Jan 24, 2017

bors-servo commented Jan 24, 2017

Ms2ger commented Jan 24, 2017

bors-servo commented Jan 24, 2017

bors-servo commented Jan 24, 2017

emilio commented Jan 24, 2017 • edited by jdm

bors-servo commented Jan 24, 2017

bors-servo commented Jan 24, 2017

SimonSapin commented Jan 24, 2017

jdm commented Jan 24, 2017

KiChjang commented Jan 24, 2017

mbrubeck commented Jan 24, 2017

bors-servo commented Jan 24, 2017

bors-servo commented Jan 24, 2017

mbrubeck commented Jan 24, 2017 •

edited by larsbergstrom

emilio commented Jan 24, 2017 •

edited

emilio commented Jan 24, 2017 •

edited by jdm