Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Auto merge of #15136 - nox:mitochondria-finally-makes-it-into… #15176

Merged
merged 1 commit into from Jan 24, 2017
Merged

Revert "Auto merge of #15136 - nox:mitochondria-finally-makes-it-into… #15176

merged 1 commit into from Jan 24, 2017

Conversation

@nox
Copy link
Member

nox commented Jan 24, 2017 •
edited by larsbergstrom

This change is Reviewable
@nox
Revert "Auto merge of #15136 - nox:mitochondria-finally-makes-it-into…
Loading status checks…
f1738ee 
…-the-tree, r=jdm"

This reverts commit ca6376a, reversing
changes made to bb24fd3.
@highfive
Copy link

highfive commented Jan 24, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/script_thread.rs, components/script/Cargo.toml, components/script/lib.rs
  • @KiChjang: components/script/script_thread.rs, components/script/Cargo.toml, components/script/lib.rs
@highfive
Copy link

highfive commented Jan 24, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 24, 2017

@bors-servo r+ p=2
@bors-servo
Copy link
Contributor

bors-servo commented Jan 24, 2017

📌 Commit f1738ee has been approved by Ms2ger
@highfive highfive assigned Ms2ger and unassigned KiChjang Jan 24, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jan 24, 2017

⌛ Testing commit f1738ee with merge af9e22a...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 24, 2017

💔 Test failed - windows-gnu-dev
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 24, 2017

@bors-servo retry p=1001
@bors-servo
Copy link
Contributor

bors-servo commented Jan 24, 2017

⌛ Testing commit f1738ee with merge 8382aaa...
bors-servo added a commit that referenced this pull request Jan 24, 2017
@bors-servo
Auto merge of #15176 - nox:the-sadness, r=Ms2ger
Loading status checks…
8382aaa 
Revert "Auto merge of #15136 - nox:mitochondria-finally-makes-it-into…

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15176)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 24, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
@bors-servo bors-servo merged commit f1738ee into servo:master Jan 24, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jan 24, 2017
Merged
4 of 4 tasks complete
This was referenced Jan 24, 2017
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @Ms2ger @bors-servo @KiChjang
You can’t perform that action at this time.