Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update url to 1.4.0 #15223

Merged
merged 1 commit into from Jan 27, 2017
Merged

update url to 1.4.0 #15223

merged 1 commit into from Jan 27, 2017

Conversation

@cbrewster
Copy link
Member

cbrewster commented Jan 25, 2017


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because updating dependencies.

This change is Reviewable

@emilio
Copy link
Member

emilio commented Jan 25, 2017

@bors-servo r+

Though I'd expect test expectations to change.

@bors-servo
Copy link
Contributor

bors-servo commented Jan 25, 2017

📌 Commit 4ce67f6 has been approved by emilio

@bors-servo
Copy link
Contributor

bors-servo commented Jan 26, 2017

The latest upstream changes (presumably #15216) made this pull request unmergeable. Please resolve the merge conflicts.

@cbrewster cbrewster closed this Jan 26, 2017
@cbrewster cbrewster force-pushed the cbrewster:urlup branch from 4ce67f6 to e4a1cb6 Jan 26, 2017
@cbrewster cbrewster reopened this Jan 26, 2017
@cbrewster
Copy link
Member Author

cbrewster commented Jan 26, 2017

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

bors-servo commented Jan 26, 2017

📌 Commit 3fc38c2 has been approved by emilio

@bors-servo
Copy link
Contributor

bors-servo commented Jan 27, 2017

Testing commit 3fc38c2 with merge e8b1241...

bors-servo added a commit that referenced this pull request Jan 27, 2017
update url to 1.4.0

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because updating dependencies.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15223)
<!-- Reviewable:end -->
@bors-servo bors-servo merged commit 3fc38c2 into servo:master Jan 27, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.