Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cargo 0.17.0-nightly (385e243 2017-01-27) #15277

Merged
merged 1 commit into from Jan 29, 2017
Merged

Update to cargo 0.17.0-nightly (385e243 2017-01-27) #15277

merged 1 commit into from Jan 29, 2017

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jan 28, 2017

Pick up rust-lang/cargo#3590, to print errors without waiting for parallel jobs.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require new tests

This change is Reviewable

Pick up rust-lang/cargo#3590,
to print errors without waiting for parallel jobs.
@emilio
Copy link
Member

emilio commented Jan 28, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2017

📌 Commit 4ae9df9 has been approved by emilio

@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2017

Testing commit 4ae9df9 with merge cfe3217...

bors-servo added a commit that referenced this pull request Jan 28, 2017
Update to cargo 0.17.0-nightly (385e243 2017-01-27)

Pick up rust-lang/cargo#3590, to print errors without waiting for parallel jobs.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require new tests

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15277)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2017

💔 Test failed - windows-gnu-dev

@SimonSapin
Copy link
Member Author

SimonSapin commented Jan 28, 2017

GeckoLib build completed in 0:02:23
LLVM ERROR: IO failure on output stream.
error: Could not compile `geckoservo`.

To learn more, run the command again with --verbose.

Let’s see if it’s a temporary thing:

@bors-servo try retry

@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2017

Trying commit 4ae9df9 with merge 063882a...

bors-servo added a commit that referenced this pull request Jan 28, 2017
Update to cargo 0.17.0-nightly (385e243 2017-01-27)

Pick up rust-lang/cargo#3590, to print errors without waiting for parallel jobs.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require new tests

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15277)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2017

💔 Test failed - windows-gnu-dev

SimonSapin added a commit that referenced this pull request Jan 28, 2017
@SimonSapin
Copy link
Member Author

SimonSapin commented Jan 28, 2017

@bors-servo try

With --verbose added.

@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2017

Trying commit efc8853 with merge 57e33ef...

bors-servo added a commit that referenced this pull request Jan 28, 2017
Update to cargo 0.17.0-nightly (385e243 2017-01-27)

Pick up rust-lang/cargo#3590, to print errors without waiting for parallel jobs.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require new tests

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15277)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2017

💔 Test failed - windows-gnu-dev

@SimonSapin
Copy link
Member Author

SimonSapin commented Jan 28, 2017

Ok, so it looks like the final rustc invocation (below) prints "LLVM ERROR: IO failure on output stream." then exists with status code 1.

The range of Cargo changes is rust-lang/cargo@6291619...385e243

rustc --crate-name geckoservo lib.rs --crate-type staticlib --crate-type rlib --emit=dep-info,link -C codegen-units=4 -C debuginfo=2 -C metadata=e50e85bcc1b97142 -C extra-filename=-e50e85bcc1b97142 --out-dir C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps -L dependency=C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps --extern lazy_static=C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps\liblazy_static-cdc27b3838abea72.rlib --extern selectors=C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps\libselectors-15cf41946cfff98b.rlib --extern parking_lot=C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps\libparking_lot-954f6d3bf6d4e2c7.rlib --extern servo_url=C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps\libservo_url-6f8bef027c9bb5eb.rlib --extern style=C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps\libstyle-40c665b2aad2742f.rlib --extern cssparser=C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps\libcssparser-450288f50f114a7f.rlib --extern atomic_refcell=C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps\libatomic_refcell-8ca19a786e0e078c.rlib --extern libc=C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps\liblibc-63a6b9527932ce3d.rlib --extern env_logger=C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps\libenv_logger-1ad4007fc38d23ae.rlib --extern log=C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps\liblog-644e3c12ff33c18f.rlib --extern num_cpus=C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps\libnum_cpus-a698a88c6ba8c5a0.rlib --extern style_traits=C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps\libstyle_traits-3e26c66e4df6fac1.rlib --extern euclid=C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps\libeuclid-d4cd13d1cb9c3b3f.rlib --extern app_units=C:\buildbot\slave\windows-gnu-dev\build\target\geckolib\debug\deps\libapp_units-f13a9ce245a65974.rlib -W unused-extern-crates

@SimonSapin
Copy link
Member Author

SimonSapin commented Jan 28, 2017

Downgrading Cargo a bit to try and narrow the range.

@bors-servo try

@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2017

Trying commit ab0e54b with merge 91821b3...

bors-servo added a commit that referenced this pull request Jan 28, 2017
Update to cargo 0.17.0-nightly (385e243 2017-01-27)

Pick up rust-lang/cargo#3590, to print errors without waiting for parallel jobs.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require new tests

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15277)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2017

💔 Test failed - windows-gnu-dev

@jdm
Copy link
Member

jdm commented Jan 28, 2017

Keep in mind servo/saltfs#585; this is not necessarily a cargo problem.

@SimonSapin
Copy link
Member Author

SimonSapin commented Jan 28, 2017

Ah, I didn’t know about that. Thanks.

@SimonSapin
Copy link
Member Author

SimonSapin commented Jan 29, 2017

servo/saltfs#585 (lack of disk space on the CI server) is closed.

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2017

📌 Commit 4ae9df9 has been approved by emilio

@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2017

Testing commit 4ae9df9 with merge c0ff8f8...

bors-servo added a commit that referenced this pull request Jan 29, 2017
Update to cargo 0.17.0-nightly (385e243 2017-01-27)

Pick up rust-lang/cargo#3590, to print errors without waiting for parallel jobs.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require new tests

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15277)
<!-- Reviewable:end -->
@bors-servo bors-servo merged commit 4ae9df9 into master Jan 29, 2017
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
dependency-ci Checking Dependencies
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the cargoup branch Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.