Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the form owner concept #15283

Closed
wants to merge 10 commits into from
Closed

Implement the form owner concept #15283

wants to merge 10 commits into from
+1,006 −167

Commits on Feb 24, 2017

  1. Implement the form owner concept

    @mukilan @canova
    mukilan authored and canova committed Feb 24, 2017
    Verified
    This commit was signed with a verified signature.
    canova Nazım Can Altınova
    GPG key ID: AF9BCD7CE6449954 Learn about signing commits
    c9ef305

  2. Update web-platform-tests expected data

    @mukilan @canova
    mukilan authored and canova committed Feb 24, 2017
    Verified
    This commit was signed with a verified signature.
    canova Nazım Can Altınova
    GPG key ID: AF9BCD7CE6449954 Learn about signing commits
    d1e0cf4

  3. Add tests for form owner concept

    @mukilan @canova
    mukilan authored and canova committed Feb 24, 2017
    Verified
    This commit was signed with a verified signature.
    canova Nazım Can Altınova
    GPG key ID: AF9BCD7CE6449954 Learn about signing commits
    4a746f7

  4. Fix failing tests

    @canova
    canova committed Feb 24, 2017
    Verified
    This commit was signed with a verified signature.
    canova Nazım Can Altınova
    GPG key ID: AF9BCD7CE6449954 Learn about signing commits
    945fda1

  5. Use one form_attribute_mutated method instead of set and remoted

    @canova
    canova committed Feb 24, 2017
    Verified
    This commit was signed with a verified signature.
    canova Nazım Can Altınova
    GPG key ID: AF9BCD7CE6449954 Learn about signing commits
    0c9edb6

  6. Fix test by not calling reset_form_owner() in unbind_form_control_fro… 

    …m_tree when it shouldn't
    @canova
    canova committed Feb 24, 2017
    Verified
    This commit was signed with a verified signature.
    canova Nazım Can Altınova
    GPG key ID: AF9BCD7CE6449954 Learn about signing commits
    c64c38e

  7. Exclude label element from form_attribute.html 

    Because label has a different form owner concept. It should reflect its control's form owner. When it doesn't have a control it should print null.
    @canova
    canova committed Feb 24, 2017
    Verified
    This commit was signed with a verified signature.
    canova Nazım Can Altınova
    GPG key ID: AF9BCD7CE6449954 Learn about signing commits
    701dca6

  8. Update test expectations

    @canova
    canova committed Feb 24, 2017
    Verified
    This commit was signed with a verified signature.
    canova Nazım Can Altınova
    GPG key ID: AF9BCD7CE6449954 Learn about signing commits
    8d80757

  9. Move control's tree bind/unbind calls to Element's tree bind/unbind m… 

    …ethods
    @canova
    canova committed Feb 24, 2017
    Verified
    This commit was signed with a verified signature.
    canova Nazım Can Altınova
    GPG key ID: AF9BCD7CE6449954 Learn about signing commits
    0d04420

  10. Address review comments

    @canova
    canova committed Feb 24, 2017
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    canova Nazım Can Altınova
    GPG key ID: AF9BCD7CE6449954 Learn about signing commits
    438c0f8
You can’t perform that action at this time.