Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused builders #15284

Merged
merged 1 commit into from Jan 30, 2017
Merged

Remove unused builders #15284

merged 1 commit into from Jan 30, 2017

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Jan 28, 2017 •
edited by larsbergstrom

These have been superseded by the windows-gnu and windows-msvc versions.
Removing them allows freeing up disk space on the Windows builders.

r? @larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@aneeshusa
Remove unused builders
Loading status checks…
6ecd045 
These have been superseded by the windows-gnu and windows-msvc versions.
Removing them allows freeing up disk space on the Windows builders.
@aneeshusa
Copy link
Member Author

aneeshusa commented Jan 28, 2017

@bors-servo try (just to make sure these really aren't being used)
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2017

⌛ Trying commit 6ecd045 with merge 6d66aac...
bors-servo added a commit that referenced this pull request Jan 28, 2017
@bors-servo
Auto merge of #15284 - aneeshusa:remove-unused-windows-builders, r=<try>
Loading status checks…
6d66aac 
Remove unused builders

These have been superseded by the windows-gnu and windows-msvc versions.
Removing them allows freeing up disk space on the Windows builders.

r? @larsbergstrom

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15284)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
@aneeshusa
Copy link
Member Author

aneeshusa commented Jan 28, 2017

Went ahead and removed the unused building dirs for windows-dev and windows-nightly on the Windows builders.
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jan 29, 2017

@bors-servo r+

Thanks for getting this!
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2017

📌 Commit 6ecd045 has been approved by larsbergstrom
@aneeshusa
Copy link
Member Author

aneeshusa commented Jan 29, 2017

@bors-servo try- r=larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2017

💡 This pull request was already approved, no need to approve it again.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2017

📌 Commit 6ecd045 has been approved by larsbergstrom
@jdm
Copy link
Member

jdm commented Jan 30, 2017

@bors-servo: clean try- r=larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #15291
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2017

📌 Commit 6ecd045 has been approved by larsbergstrom
@jdm
Copy link
Member

jdm commented Jan 30, 2017

@bors-servo: try- retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2017

⌛ Testing commit 6ecd045 with merge 9cdf78d...
bors-servo added a commit that referenced this pull request Jan 30, 2017
@bors-servo
Auto merge of #15284 - aneeshusa:remove-unused-windows-builders, r=la…
Loading status checks…
9cdf78d 
…rsbergstrom

Remove unused builders

These have been superseded by the windows-gnu and windows-msvc versions.
Removing them allows freeing up disk space on the Windows builders.

r? @larsbergstrom

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15284)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
@bors-servo bors-servo merged commit 6ecd045 into servo:master Jan 30, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@larsbergstrom larsbergstrom

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@aneeshusa @bors-servo @larsbergstrom @jdm @highfive
You can’t perform that action at this time.