New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #15017: Properly handle and report network errors on page loads. #15285

Merged
merged 1 commit into from Feb 3, 2017

Conversation

Projects
None yet
5 participants
@simartin
Contributor

simartin commented Jan 28, 2017

This patch fixes how network errors are handled during page loads: they would not be reported and cause crashes before, and do not anymore.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #15017 (github issue number if applicable).
  • There are tests for these changes

This change is Reviewable

@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Jan 28, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/servoparser/mod.rs
  • @KiChjang: components/script/dom/servoparser/mod.rs

highfive commented Jan 28, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/servoparser/mod.rs
  • @KiChjang: components/script/dom/servoparser/mod.rs
@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Jan 28, 2017

warning Warning warning

  • These commits include an empty title element (<title></title>). Consider adding appropriate metadata.

highfive commented Jan 28, 2017

warning Warning warning

  • These commits include an empty title element (<title></title>). Consider adding appropriate metadata.
@pcwalton

This comment has been minimized.

Show comment
Hide comment
@pcwalton

pcwalton Jan 31, 2017

Contributor

Over to @nox

Contributor

pcwalton commented Jan 31, 2017

Over to @nox

@pcwalton pcwalton removed their assignment Jan 31, 2017

@nox

This comment has been minimized.

Show comment
Hide comment
@nox
Member

nox commented Feb 3, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 3, 2017

Contributor

📌 Commit abc9f78 has been approved by nox

Contributor

bors-servo commented Feb 3, 2017

📌 Commit abc9f78 has been approved by nox

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 3, 2017

Contributor

⌛️ Testing commit abc9f78 with merge f0e21d0...

Contributor

bors-servo commented Feb 3, 2017

⌛️ Testing commit abc9f78 with merge f0e21d0...

bors-servo added a commit that referenced this pull request Feb 3, 2017

Auto merge of #15285 - simartin:issue_15017, r=nox
Issue #15017: Properly handle and report network errors on page loads.

<!-- Please describe your changes on the following line: -->
This patch fixes how network errors are handled during page loads: they would not be reported and cause crashes before, and do not anymore.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15017 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15285)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo
Contributor

bors-servo commented Feb 3, 2017

@bors-servo bors-servo merged commit abc9f78 into servo:master Feb 3, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@simartin simartin deleted the simartin:issue_15017 branch Feb 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment