New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement document.open and document.close #15303

Merged
merged 2 commits into from Feb 3, 2017

Conversation

Projects
None yet
6 participants
@nox
Member

nox commented Jan 30, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Jan 30, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/document.rs, components/script/dom/eventtarget.rs, components/script/dom/webidls/Document.webidl, components/script/dom/servoparser/mod.rs, components/script/dom/bindings/str.rs, components/script/dom/window.rs
  • @KiChjang: components/script/dom/document.rs, components/script/dom/eventtarget.rs, components/script/dom/webidls/Document.webidl, components/script/dom/servoparser/mod.rs, components/script/dom/bindings/str.rs, components/script/dom/window.rs

highfive commented Jan 30, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/document.rs, components/script/dom/eventtarget.rs, components/script/dom/webidls/Document.webidl, components/script/dom/servoparser/mod.rs, components/script/dom/bindings/str.rs, components/script/dom/window.rs
  • @KiChjang: components/script/dom/document.rs, components/script/dom/eventtarget.rs, components/script/dom/webidls/Document.webidl, components/script/dom/servoparser/mod.rs, components/script/dom/bindings/str.rs, components/script/dom/window.rs
@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Jan 30, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

highfive commented Jan 30, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox

This comment has been minimized.

Show comment
Hide comment
@nox
Member

nox commented Jan 30, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Jan 30, 2017

Contributor

⌛️ Trying commit 6111d92 with merge 3d221da...

Contributor

bors-servo commented Jan 30, 2017

⌛️ Trying commit 6111d92 with merge 3d221da...

bors-servo added a commit that referenced this pull request Jan 30, 2017

Auto merge of #15303 - nox:open-your-heart-to-eternal-dimension, r=<try>
[Do not merge] Implement document.open and document.close
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Jan 30, 2017

Contributor

💔 Test failed - windows-gnu-dev

Contributor

bors-servo commented Jan 30, 2017

💔 Test failed - windows-gnu-dev

@KiChjang

This comment has been minimized.

Show comment
Hide comment
@KiChjang

KiChjang Jan 30, 2017

Member

@bors-servo retry
wat

Member

KiChjang commented Jan 30, 2017

@bors-servo retry
wat

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Jan 30, 2017

Contributor

⌛️ Trying commit 6111d92 with merge 7e6888a...

Contributor

bors-servo commented Jan 30, 2017

⌛️ Trying commit 6111d92 with merge 7e6888a...

bors-servo added a commit that referenced this pull request Jan 30, 2017

Auto merge of #15303 - nox:open-your-heart-to-eternal-dimension, r=<try>
[Do not merge] Implement document.open and document.close

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15303)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Jan 30, 2017

Contributor

💔 Test failed - linux-rel-wpt

Contributor

bors-servo commented Jan 30, 2017

💔 Test failed - linux-rel-wpt

@nox

This comment has been minimized.

Show comment
Hide comment
@nox

nox Jan 30, 2017

Member

Not going to lie, I expected way more passing tests, hah.

Will investigate.

@bors-servo try

Member

nox commented Jan 30, 2017

Not going to lie, I expected way more passing tests, hah.

Will investigate.

@bors-servo try

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Jan 30, 2017

Contributor

⌛️ Trying commit f556986 with merge 139fa26...

Contributor

bors-servo commented Jan 30, 2017

⌛️ Trying commit f556986 with merge 139fa26...

bors-servo added a commit that referenced this pull request Jan 30, 2017

Auto merge of #15303 - nox:open-your-heart-to-eternal-dimension, r=<try>
[Do not merge] Implement document.open and document.close

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15303)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Jan 31, 2017

Contributor

💥 Test timed out

Contributor

bors-servo commented Jan 31, 2017

💥 Test timed out

@nox

This comment has been minimized.

Show comment
Hide comment
@nox

nox Jan 31, 2017

Member

Fascinating.

@bors-servo retry

Member

nox commented Jan 31, 2017

Fascinating.

@bors-servo retry

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Jan 31, 2017

Contributor

⌛️ Trying commit f556986 with merge 2fafd0d...

Contributor

bors-servo commented Jan 31, 2017

⌛️ Trying commit f556986 with merge 2fafd0d...

bors-servo added a commit that referenced this pull request Jan 31, 2017

Auto merge of #15303 - nox:open-your-heart-to-eternal-dimension, r=<try>
[Do not merge] Implement document.open and document.close

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15303)
<!-- Reviewable:end -->

@nox nox changed the title from [Do not merge] Implement document.open and document.close to Implement document.open and document.close Jan 31, 2017

@nox

This comment has been minimized.

Show comment
Hide comment
@nox

nox Jan 31, 2017

Member

IMO this is ready to be reviewed and merged.

r? @jdm

Member

nox commented Jan 31, 2017

IMO this is ready to be reviewed and merged.

r? @jdm

@highfive highfive assigned jdm and unassigned emilio Jan 31, 2017

@nox

This comment has been minimized.

Show comment
Hide comment
@nox
Member

nox commented Jan 31, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Jan 31, 2017

Contributor

⌛️ Trying commit a4150aa with merge dddeb83...

Contributor

bors-servo commented Jan 31, 2017

⌛️ Trying commit a4150aa with merge dddeb83...

bors-servo added a commit that referenced this pull request Jan 31, 2017

Auto merge of #15303 - nox:open-your-heart-to-eternal-dimension, r=<try>
Implement document.open and document.close

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15303)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Jan 31, 2017

Contributor

💔 Test failed - linux-rel-wpt

Contributor

bors-servo commented Jan 31, 2017

💔 Test failed - linux-rel-wpt

@nox

This comment has been minimized.

Show comment
Hide comment
@nox
Member

nox commented Jan 31, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Jan 31, 2017

Contributor

⌛️ Trying commit 3c833d4 with merge 3a141c4...

Contributor

bors-servo commented Jan 31, 2017

⌛️ Trying commit 3c833d4 with merge 3a141c4...

bors-servo added a commit that referenced this pull request Jan 31, 2017

Auto merge of #15303 - nox:open-your-heart-to-eternal-dimension, r=<try>
Implement document.open and document.close

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15303)
<!-- Reviewable:end -->
@nox

This comment has been minimized.

Show comment
Hide comment
@nox
Member

nox commented Feb 1, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 1, 2017

Contributor

⌛️ Trying commit 5c42235 with merge 254f013...

Contributor

bors-servo commented Feb 1, 2017

⌛️ Trying commit 5c42235 with merge 254f013...

bors-servo added a commit that referenced this pull request Feb 1, 2017

Auto merge of #15303 - nox:open-your-heart-to-eternal-dimension, r=<try>
Implement document.open and document.close

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15303)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@jdm

Nice work. Lots of TODOs, but I think it's worth landing these changes without trying to coordinate with the session history stuff right now.

Show outdated Hide outdated components/script/dom/document.rs Outdated
Show outdated Hide outdated components/script/dom/document.rs Outdated
Show outdated Hide outdated components/script/dom/servoparser/mod.rs Outdated
Show outdated Hide outdated components/script/dom/window.rs Outdated
Show outdated Hide outdated .../html/dom/dynamic-markup-insertion/opening-the-input-stream/016.html.ini Outdated
@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Feb 2, 2017

Member

That being said, we should definitely file some issues about integrating with session history before merging.

Member

jdm commented Feb 2, 2017

That being said, we should definitely file some issues about integrating with session history before merging.

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm
Member

jdm commented Feb 3, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 3, 2017

Contributor

📌 Commit ac25404 has been approved by jdm

Contributor

bors-servo commented Feb 3, 2017

📌 Commit ac25404 has been approved by jdm

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 3, 2017

Contributor

⌛️ Testing commit ac25404 with merge fa60ce6...

Contributor

bors-servo commented Feb 3, 2017

⌛️ Testing commit ac25404 with merge fa60ce6...

bors-servo added a commit that referenced this pull request Feb 3, 2017

Auto merge of #15303 - nox:open-your-heart-to-eternal-dimension, r=jdm
Implement document.open and document.close

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15303)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo
Contributor

bors-servo commented Feb 3, 2017

@bors-servo bors-servo merged commit ac25404 into servo:master Feb 3, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@nox nox deleted the nox:open-your-heart-to-eternal-dimension branch Feb 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment