New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root the arguments to callback functions. #15326

Merged
merged 1 commit into from Feb 1, 2017

Conversation

Projects
None yet
5 participants
@Ms2ger
Contributor

Ms2ger commented Feb 1, 2017

Note that this relies on the fact that Heap and JSVal are binary
compatible.

Fixes #15324.


This change is Reviewable

Root the arguments to callback functions.
Note that this relies on the fact that Heap<JSVal> and JSVal are binary
compatible.

Fixes #15324.
@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Feb 1, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/bindings/codegen/CodegenRust.py
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py

highfive commented Feb 1, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/bindings/codegen/CodegenRust.py
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py
@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Feb 1, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

highfive commented Feb 1, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox

This comment has been minimized.

Show comment
Hide comment
@nox
Member

nox commented Feb 1, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 1, 2017

Contributor

📌 Commit d9013e0 has been approved by nox

Contributor

bors-servo commented Feb 1, 2017

📌 Commit d9013e0 has been approved by nox

@highfive highfive assigned nox and unassigned wafflespeanut Feb 1, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 1, 2017

Contributor

⌛️ Testing commit d9013e0 with merge 4524bb2...

Contributor

bors-servo commented Feb 1, 2017

⌛️ Testing commit d9013e0 with merge 4524bb2...

bors-servo added a commit that referenced this pull request Feb 1, 2017

Auto merge of #15326 - servo:root-callback-args, r=nox
Root the arguments to callback functions.

Note that this relies on the fact that Heap<JSVal> and JSVal are binary
compatible.

Fixes #15324.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15326)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment

@bors-servo bors-servo merged commit d9013e0 into master Feb 1, 2017

2 of 4 checks passed

dependency-ci An error occured
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@SimonSapin SimonSapin deleted the root-callback-args branch Feb 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment