New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse value entirely for setting property via CSSOM #15338

Merged
merged 1 commit into from Feb 3, 2017

Conversation

Projects
None yet
6 participants
@upsuper
Member

upsuper commented Feb 2, 2017

Fixes #15037


This change is Reviewable

@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Feb 2, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/declaration_block.rs
  • @emilio: components/style/properties/declaration_block.rs

highfive commented Feb 2, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/declaration_block.rs
  • @emilio: components/style/properties/declaration_block.rs
@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Feb 2, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

highfive commented Feb 2, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@upsuper

This comment has been minimized.

Show comment
Hide comment
@upsuper
Member

upsuper commented Feb 2, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 2, 2017

Contributor

⌛️ Trying commit d06ffc2 with merge 687d463...

Contributor

bors-servo commented Feb 2, 2017

⌛️ Trying commit d06ffc2 with merge 687d463...

bors-servo added a commit that referenced this pull request Feb 2, 2017

Auto merge of #15338 - upsuper:parse_one_decl, r=<try>
Parse value entirely for setting property via CSSOM

Fixes #15037
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo
Contributor

bors-servo commented Feb 2, 2017

@emilio

This comment has been minimized.

Show comment
Hide comment
@emilio
Member

emilio commented Feb 2, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 2, 2017

Contributor

📌 Commit d06ffc2 has been approved by emilio

Contributor

bors-servo commented Feb 2, 2017

📌 Commit d06ffc2 has been approved by emilio

@highfive highfive assigned emilio and unassigned metajack Feb 2, 2017

@emilio

This comment has been minimized.

Show comment
Hide comment
@emilio

emilio Feb 3, 2017

Member

@bors-servo clean try- r-

Member

emilio commented Feb 3, 2017

@bors-servo clean try- r-

@emilio

This comment has been minimized.

Show comment
Hide comment
@emilio
Member

emilio commented Feb 3, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 3, 2017

Contributor

📌 Commit d06ffc2 has been approved by emilio

Contributor

bors-servo commented Feb 3, 2017

📌 Commit d06ffc2 has been approved by emilio

@KiChjang

This comment has been minimized.

Show comment
Hide comment
@KiChjang
Member

KiChjang commented Feb 3, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 3, 2017

Contributor

⌛️ Testing commit d06ffc2 with merge 812a3a1...

Contributor

bors-servo commented Feb 3, 2017

⌛️ Testing commit d06ffc2 with merge 812a3a1...

bors-servo added a commit that referenced this pull request Feb 3, 2017

Auto merge of #15338 - upsuper:parse_one_decl, r=emilio
Parse value entirely for setting property via CSSOM

Fixes #15037

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15338)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo
Contributor

bors-servo commented Feb 3, 2017

@bors-servo bors-servo merged commit d06ffc2 into servo:master Feb 3, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@upsuper upsuper deleted the upsuper:parse_one_decl branch Feb 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment