Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for mask_position_parse/serial #15383

Merged
merged 1 commit into from Feb 4, 2017
Merged

add support for mask_position_parse/serial #15383

merged 1 commit into from Feb 4, 2017

Conversation

@mrmiywj
Copy link
Contributor

mrmiywj commented Feb 4, 2017 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #14955 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@mrmiywj
add support for mask_position_parse/serial
Loading status checks…
eb115e0
@highfive
Copy link

highfive commented Feb 4, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/shorthand/mask.mako.rs, components/style/properties/gecko.mako.rs, components/style/properties/longhand/svg.mako.rs
  • @emilio: components/style/properties/shorthand/mask.mako.rs, components/style/properties/gecko.mako.rs, components/style/properties/longhand/svg.mako.rs
@mrmiywj mrmiywj mentioned this pull request Feb 4, 2017
Closed
1 of 5 tasks complete
@mrmiywj
Copy link
Contributor Author

mrmiywj commented Feb 4, 2017

It is the squashed commits of #15092.
@mrmiywj
Copy link
Contributor Author

mrmiywj commented Feb 4, 2017

PTAL @canaltinova
@canova
Copy link
Member

canova commented Feb 4, 2017

I don't have a permission for this PR, we need to wait for someone to approve this. Thanks for working on it! It was great amount of work!

Btw, log history in other PR doesn't matter for squash. You could still rebase it and force push it to your branch. This is fine too though.
@KiChjang
Copy link
Member

KiChjang commented Feb 4, 2017

Indeed, git rebase -i should have allowed you to squash as well, instead of opening a new PR branch. Thanks for working on this!

@bors-servo r=canaltinova
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2017

📌 Commit eb115e0 has been approved by canaltinova
@highfive highfive assigned canova and unassigned pcwalton Feb 4, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2017

⌛ Testing commit eb115e0 with merge 97cc71b...
bors-servo added a commit that referenced this pull request Feb 4, 2017
@bors-servo
Auto merge of #15383 - mrmiywj:mask_position_parse/serial, r=canaltinova
Loading status checks…
97cc71b 
add support for mask_position_parse/serial

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14955  (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15383)
<!-- Reviewable:end -->
@KiChjang
Copy link
Member

KiChjang commented Feb 4, 2017

@bors-servo delegate=canaltinova
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2017

✌️ @canaltinova can now approve this pull request
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2017

💔 Test failed - linux-rel-wpt
@canova
Copy link
Member

canova commented Feb 4, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: canaltinova
Pushing 97cc71b to master...
@bors-servo bors-servo merged commit eb115e0 into servo:master Feb 4, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@canova canova

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement parsing/serialization for mask-position-{x,y}
6 participants
@mrmiywj @highfive @canova @KiChjang @bors-servo @pcwalton
You can’t perform that action at this time.