Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upandroid: extract resources to external storage on first launch #15396
Conversation
highfive
commented
Feb 6, 2017
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon. |
|
@larsbergstrom is this ok? |
|
@bors-servo r+ @zhuowei This is an AMAZING first version - thanks a ton! It will really especially help for new users grabbing the APK for the first time. We can work on a follow-update later that handles extracting updated versions / doing cleanup, but this provides a much improved experience and a good basis for that next step. |
|
|
…trom android: extract resources to external storage on first launch <!-- Please describe your changes on the following line: --> If /sdcard/servo doesn't exist, extract it from the assets/ folder of the APK. This fixes issue #12129. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12129 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> I tested this on a Nexus 6P running Android 7.1: on launch, the app correctly detects that /sdcard/servo is missing, extracts the contents from assets/, and launches without force closing. This is my first Servo pull request, so apologies in advance if I'm doing something wrong. Also, I was unable to build the entirety of Servo from source (complains about missing freetype), so I just built the Java portion separately; would that impact anything? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15396) <!-- Reviewable:end -->
|
|
zhuowei commentedFeb 6, 2017
•
edited by jdm
If /sdcard/servo doesn't exist, extract it from the assets/ folder of the APK. This fixes issue #12129.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsI tested this on a Nexus 6P running Android 7.1: on launch, the app correctly detects that /sdcard/servo is missing, extracts the contents from assets/, and launches without force closing.
This is my first Servo pull request, so apologies in advance if I'm doing something wrong. Also, I was unable to build the entirety of Servo from source (complains about missing freetype), so I just built the Java portion separately; would that impact anything?
This change is