Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MutHeapJSVal #15408

Closed
wants to merge 1 commit into from
Closed

Remove MutHeapJSVal #15408

wants to merge 1 commit into from

Conversation

@chansuke
Copy link
Contributor

chansuke commented Feb 6, 2017 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #15316 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
chansuke
Remove MutHeapJSVal & replaced with Heap<JSVal>
Loading status checks…
f62a5b4
@highfive
Copy link

highfive commented Feb 6, 2017

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.
@highfive
Copy link

highfive commented Feb 6, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/bindings/js.rs, components/script/dom/bindings/callback.rs
  • @KiChjang: components/script/dom/bindings/js.rs, components/script/dom/bindings/callback.rs
@jdm
Copy link
Member

jdm commented Feb 6, 2017

@chansuke The original issue suggested removing the type entirely and replacing all uses of it with Heap<JSVal> instead.
@jdm
Copy link
Member

jdm commented Feb 13, 2017

@chansuke Are you planning to continue this work?
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2017

☔ The latest upstream changes (presumably #15559) made this pull request unmergeable. Please resolve the merge conflicts.
@chansuke
Copy link
Contributor Author

chansuke commented Feb 16, 2017

@jdm Sorry for the late reply.Yes,I want to continue the work.
@jdm
Copy link
Member

jdm commented Mar 3, 2017

Closing due to inactivity.
@jdm jdm closed this Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
S-needs-code-changes S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Remove MutHeapJSVal
6 participants
@chansuke @highfive @jdm @bors-servo @metajack @KiChjang
You can’t perform that action at this time.