Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed invalid FIXME #15429

Merged
merged 1 commit into from Feb 8, 2017
Merged

removed invalid FIXME #15429

merged 1 commit into from Feb 8, 2017
+0 −2

Conversation

@ghost
Copy link

ghost commented Feb 7, 2017 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because I just removed two lines

This change is Reviewable
z1mvader
removed invalid FIXME
Loading status checks…
6bf5c24
@highfive
Copy link

highfive commented Feb 7, 2017

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @cbrewster (or someone else) soon.
@highfive
Copy link

highfive commented Feb 7, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/shorthand/box.mako.rs
  • @emilio: components/style/properties/shorthand/box.mako.rs
@highfive
Copy link

highfive commented Feb 7, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Feb 7, 2017

@bors-servo: r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2017

📌 Commit 6bf5c24 has been approved by jdm
@highfive highfive assigned jdm and unassigned cbrewster Feb 7, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2017

⌛ Testing commit 6bf5c24 with merge 8dd085d...
bors-servo added a commit that referenced this pull request Feb 7, 2017
@bors-servo
Auto merge of #15429 - z1mvader:master, r=jdm
Loading status checks…
8dd085d 
removed invalid FIXME

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because I just removed two lines

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15429)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2017

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Feb 7, 2017

@bors-servo: retry
#15435
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2017

⌛ Testing commit 6bf5c24 with merge ec393b8...
bors-servo added a commit that referenced this pull request Feb 7, 2017
@bors-servo
Auto merge of #15429 - z1mvader:master, r=jdm
Loading status checks…
ec393b8 
removed invalid FIXME

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because I just removed two lines

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15429)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2017

💔 Test failed - linux-rel-wpt
@KiChjang
Copy link
Member

KiChjang commented Feb 8, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: jdm
Pushing ec393b8 to master...
@bors-servo bors-servo merged commit 6bf5c24 into servo:master Feb 8, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@wafflespeanut wafflespeanut mentioned this pull request Feb 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@highfive @jdm @bors-servo @KiChjang @cbrewster
You can’t perform that action at this time.