Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline unwrapCastableObject into its only caller. #15453

Merged
merged 1 commit into from Feb 8, 2017
Merged

Inline unwrapCastableObject into its only caller. #15453

merged 1 commit into from Feb 8, 2017

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 8, 2017 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Feb 8, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/bindings/codegen/CodegenRust.py
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py
@highfive
Copy link

highfive commented Feb 8, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Feb 8, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2017

📌 Commit 27ece64 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2017

⌛ Testing commit 27ece64 with merge c1be716...
bors-servo added a commit that referenced this pull request Feb 8, 2017
@bors-servo
Auto merge of #15453 - servo:unwrapCastableObject, r=nox
Loading status checks…
c1be716 
Inline unwrapCastableObject into its only caller.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15453)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2017

💔 Test failed - linux-dev
@Ms2ger
Inline unwrapCastableObject into its only caller.
Loading status checks…
350a970
@Ms2ger Ms2ger force-pushed the unwrapCastableObject branch from 27ece64 to 350a970 Feb 8, 2017
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 8, 2017

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2017

📌 Commit 350a970 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2017

⌛ Testing commit 350a970 with merge 6d1d4b5...
bors-servo added a commit that referenced this pull request Feb 8, 2017
@bors-servo
Auto merge of #15453 - servo:unwrapCastableObject, r=nox
Loading status checks…
6d1d4b5 
Inline unwrapCastableObject into its only caller.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15453)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2017

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Feb 8, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: nox
Pushing 6d1d4b5 to master...
@bors-servo bors-servo merged commit 350a970 into master Feb 8, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the unwrapCastableObject branch Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @nox @bors-servo @jdm
You can’t perform that action at this time.