Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstyle: Ensure that precomputed pseudo-element declarations are correctly sorted. #15459
Conversation
|
|
||
| // We need to insert important rules _after_ normal rules for this to be | ||
| // correct, and also to not trigger rule tree assertions. |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
|
|
style: Ensure that precomputed pseudo-element declarations are correctly sorted. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1337657 r? @SimonSapin <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15459) <!-- Reviewable:end -->
|
|
error: method `get_universal_rules` is private
--> /home/servo/buildbot/slave/linux-dev/build/tests/unit/style/stylist.rs:117:9
|
117 | map.get_universal_rules(&mut decls,
| ^^^^^^^^^^^^^^^^^^^
error: aborting due to previous error
error: Could not compile `style_tests`. |
…tly sorted.
|
Whoops. @bors-servo r=SimonSapin |
|
|
style: Ensure that precomputed pseudo-element declarations are correctly sorted. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1337657 r? @SimonSapin <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15459) <!-- Reviewable:end -->
|
|
|
@bors-servo retry #15239 |
|
|
|
|
emilio commentedFeb 8, 2017
•
edited by larsbergstrom
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1337657
r? @SimonSapin
This change is