New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-added parsing and serialization for grid-{row,column}-gap #15466
Merged
+14
−0
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Loading status checks…
-added parsing and serialization for grid-{row,column}-gap
updated missing products='gecko' in grid-row-gap and grip-column-gap
- Loading branch information
commit 07012279061baa5221d0eb2bc7ccd19f5f299aa9
| @@ -220,3 +220,17 @@ ${helpers.single_keyword("object-fit", "fill contain cover none scale-down", | ||
| spec="https://drafts.csswg.org/css-grid/#propdef-%s" % longhand, | ||
| products="gecko")} | ||
| % endfor | ||
|
|
||
| ${helpers.predefined_type("grid-row-gap", | ||
| "LengthOrPercentage", | ||
hiei23
Author
Contributor
|
||
| "computed::LengthOrPercentage::Length(Au(0))", | ||
| spec="https://drafts.csswg.org/css-grid/#propdef-grid-row-gap", | ||
| animatable=True, | ||
| products="gecko")} | ||
|
|
||
| ${helpers.predefined_type("grid-column-gap", | ||
| "LengthOrPercentage", | ||
| "computed::LengthOrPercentage::Length(Au(0))", | ||
| spec="https://drafts.csswg.org/css-grid/#propdef-grid-column-gap", | ||
| animatable=True, | ||
| products="gecko")} | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
You should add a
products=geckohere (and below) in order for the build to succeed. We don't have grid support in Servo right now.