Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-added parsing and serialization for grid-{row,column}-gap #15466

Merged
merged 1 commit into from Feb 10, 2017
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

-added parsing and serialization for grid-{row,column}-gap

updated missing products='gecko' in grid-row-gap and grip-column-gap
  • Loading branch information
hiei23 committed Feb 10, 2017
commit 07012279061baa5221d0eb2bc7ccd19f5f299aa9
@@ -220,3 +220,17 @@ ${helpers.single_keyword("object-fit", "fill contain cover none scale-down",
spec="https://drafts.csswg.org/css-grid/#propdef-%s" % longhand,
products="gecko")}
% endfor

${helpers.predefined_type("grid-row-gap",
"LengthOrPercentage",

This comment has been minimized.

@wafflespeanut

wafflespeanut Feb 9, 2017

Member

You should add a products=gecko here (and below) in order for the build to succeed. We don't have grid support in Servo right now.

This comment has been minimized.

@hiei23

hiei23 Feb 9, 2017

Author Contributor

OK. so do i have to implement it using the template based on https://github.com/servo/servo/wiki/Property-hacking-guide ?

This comment has been minimized.

@wafflespeanut

wafflespeanut Feb 9, 2017

Member

No, just adding products='gecko' here will make this work.

"computed::LengthOrPercentage::Length(Au(0))",
spec="https://drafts.csswg.org/css-grid/#propdef-grid-row-gap",
animatable=True,
products="gecko")}

${helpers.predefined_type("grid-column-gap",
"LengthOrPercentage",
"computed::LengthOrPercentage::Length(Au(0))",
spec="https://drafts.csswg.org/css-grid/#propdef-grid-column-gap",
animatable=True,
products="gecko")}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.