Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unwrap(), not needed #15468
Remove unwrap(), not needed #15468
Conversation
highfive
commented
Feb 9, 2017
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon. |
highfive
commented
Feb 9, 2017
highfive
commented
Feb 9, 2017
|
aaa, i think i need to rebase. |
| @@ -1590,7 +1590,7 @@ impl ScriptThread { | |||
| let chan = &load.layout_chan; | |||
| if chan.send(message::Msg::PrepareToExit(response_chan)).is_ok() { | |||
| debug!("shutting down layout for page {}", id); | |||
| response_port.recv().unwrap(); | |||
| response_port.recv(); | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
karan1276
Feb 9, 2017
Author
Contributor
Anonymous let will be let response_port.recv(); thats all right?
This comment has been minimized.
This comment has been minimized.
|
I can't really understand the conflicting code. If someone can tell me how to go about this it will be great. Thanks :) |
|
And, it will write the the conflicts to the file. Then, you can update the file with your changes, |
|
@wafflespeanut awesome! |
|
something went wrong, i messed up my git history. Ill open a new PR |
karan1276 commentedFeb 9, 2017
•
edited
Fixes #15387
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is