Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unwrap(), not needed #15470

Merged
merged 1 commit into from Feb 13, 2017
Merged

remove unwrap(), not needed #15470

merged 1 commit into from Feb 13, 2017

Conversation

@karan1276
Copy link
Contributor

karan1276 commented Feb 9, 2017 •
edited by larsbergstrom

Fixes #15387

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Feb 9, 2017

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon.
@highfive
Copy link

highfive commented Feb 9, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/script_thread.rs
  • @KiChjang: components/script/script_thread.rs
@highfive
Copy link

highfive commented Feb 9, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@karan1276
Copy link
Contributor Author

karan1276 commented Feb 9, 2017

@wafflespeanut please review
@wafflespeanut
Copy link
Member

wafflespeanut commented Feb 9, 2017

Please change the commit message to something more specific like, "Remove usage of unwrap in handle_exit_pipeline_msg"
@asajeffrey
Copy link
Member

asajeffrey commented Feb 9, 2017

Seems like a sensible change to me, thanks!
@karan1276 karan1276 force-pushed the karan1276:karan_rmv_unwrap branch from 9992be2 to fc11645 Feb 11, 2017
@KiChjang
Copy link
Member

KiChjang commented Feb 11, 2017

The commit message has a typo, handel instead of handle.
@karan1276
Remove usage of unwrap in handle_exit_pipeline_msg()
Loading status checks…
abcd813
@karan1276 karan1276 force-pushed the karan1276:karan_rmv_unwrap branch from fc11645 to abcd813 Feb 13, 2017
@wafflespeanut
Copy link
Member

wafflespeanut commented Feb 13, 2017

Thanks!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2017

📌 Commit abcd813 has been approved by Wafflespeanut
@highfive highfive assigned wafflespeanut and unassigned asajeffrey Feb 13, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2017

⌛ Testing commit abcd813 with merge 28d62f0...
bors-servo added a commit that referenced this pull request Feb 13, 2017
@bors-servo
Auto merge of #15470 - karan1276:karan_rmv_unwrap, r=Wafflespeanut
Loading status checks…
28d62f0 
remove unwrap(), not needed

Fixes #15387

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15470)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: Wafflespeanut
Pushing 28d62f0 to master...
@bors-servo bors-servo merged commit abcd813 into servo:master Feb 13, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Remove use of unwrap in handle_exit_pipeline_msg
7 participants
@karan1276 @highfive @wafflespeanut @asajeffrey @KiChjang @bors-servo @jdm
You can’t perform that action at this time.