Added harfbuzz-devel to Fedora's dependencies in README

[kvark]

---

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes fix #__ (github issue number if applicable).

• There are tests for these changes OR
• These changes do not require tests because it's for README

---

This change is 

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon.

[asajeffrey]

This change looks very sensible! Is harfbuzz-devel needed on all versions of Fedora?

[kvark]

@asajeffrey that I don't know. I just had a fresh setup of Fedora 25 (Gnome), and doing mach build -r on servo after performing the initial dependency install failed to link due to the harfbuzz stuff. Installing that missing devel package fixes it. I suppose there is no harm adding it to README, even if on some Fedora spins it's already installed.

[aneeshusa]

If harfbuzz-devel is needed, please consider upstreaming this to saltfs for ./mach bootstrap.

[jdm]

We always build harfbuzz from scratch on Windows, and we seem to use the system harfbuzz if it's present on other platforms, and build it from scratch if it's not.

[asajeffrey]

@kvark can you send the log for the build failure you had without harfbuzz-devel? It should have built from the harfbuzz source that's in-tree.

[kvark]

[kvark@carbon servo]$ ./mach build -r
    Updating git repository `https://github.com/servo/rust-azure`
 Downloading gleam v0.2.32
 Downloading servo-glutin v0.8.0
 Downloading offscreen_gl_context v0.5.4
 Downloading servo-skia v0.30000001.0
 Downloading xi-unicode v0.1.0
 Downloading x11 v2.12.1
 Downloading metadeps v1.1.1
 Downloading toml v0.2.1
 Downloading error-chain v0.7.2
 Downloading x11-dl v2.12.0
   Compiling toml v0.2.1
   Compiling webrender v0.15.0 (https://github.com/servo/webrender#512b4a14)
   Compiling error-chain v0.7.2
   Compiling webrender_traits v0.14.0 (https://github.com/servo/webrender#512b4a14)
   Compiling xi-unicode v0.1.0
   Compiling azure v0.11.0 (https://github.com/servo/rust-azure#5cdfed26)
   Compiling x11-dl v2.12.0
   Compiling selectors v0.18.0 (file:///home/kvark/Code/servo/components/selectors)
   Compiling style_traits v0.0.1 (file:///home/kvark/Code/servo/components/style_traits)
   Compiling offscreen_gl_context v0.5.4
   Compiling gleam v0.2.32
   Compiling metadeps v1.1.1
   Compiling x11 v2.12.1
   Compiling servo-glutin v0.8.0
   Compiling servo-skia v0.30000001.0
   Compiling script v0.0.1 (file:///home/kvark/Code/servo/components/script)
   Compiling style v0.0.1 (file:///home/kvark/Code/servo/components/style)
   Compiling canvas_traits v0.0.1 (file:///home/kvark/Code/servo/components/canvas_traits)
   Compiling msg v0.0.1 (file:///home/kvark/Code/servo/components/msg)
   Compiling net_traits v0.0.1 (file:///home/kvark/Code/servo/components/net_traits)
   Compiling devtools_traits v0.0.1 (file:///home/kvark/Code/servo/components/devtools_traits)
   Compiling devtools v0.0.1 (file:///home/kvark/Code/servo/components/devtools)
   Compiling canvas v0.0.1 (file:///home/kvark/Code/servo/components/canvas)
   Compiling net v0.0.1 (file:///home/kvark/Code/servo/components/net)
   Compiling webvr_traits v0.0.1 (file:///home/kvark/Code/servo/components/webvr_traits)
   Compiling script_traits v0.0.1 (file:///home/kvark/Code/servo/components/script_traits)
   Compiling webdriver_server v0.0.1 (file:///home/kvark/Code/servo/components/webdriver_server)
   Compiling webvr v0.0.1 (file:///home/kvark/Code/servo/components/webvr)
   Compiling compositing v0.0.1 (file:///home/kvark/Code/servo/components/compositing)
   Compiling glutin_app v0.0.1 (file:///home/kvark/Code/servo/ports/glutin)
   Compiling gfx v0.0.1 (file:///home/kvark/Code/servo/components/gfx)
   Compiling script_layout_interface v0.0.1 (file:///home/kvark/Code/servo/components/script_layout_interface)
   Compiling layout_traits v0.0.1 (file:///home/kvark/Code/servo/components/layout_traits)
   Compiling layout v0.0.1 (file:///home/kvark/Code/servo/components/layout)
   Compiling constellation v0.0.1 (file:///home/kvark/Code/servo/components/constellation)
   Compiling layout_thread v0.0.1 (file:///home/kvark/Code/servo/components/layout_thread)
   Compiling libservo v0.0.1 (file:///home/kvark/Code/servo/components/servo)
   Compiling servo v0.0.1 (file:///home/kvark/Code/servo/ports/servo)
error: linking with `cc` failed: exit code: 1
  |
  = note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m64" "-L" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/home/kvark/Code/servo/target/release/deps/servo-874e108b02796aec.0.o" "-o" "/home/kvark/Code/servo/target/release/deps/servo-874e108b02796aec" "-Wl,--gc-sections" "-pie" "-Wl,-O1" "-nodefaultlibs" "-L" "/home/kvark/Code/servo/target/release/deps" "-L" "/usr/lib64" "-L" "/usr/lib64" "-L" "/home/kvark/Code/servo/target/release/build/openssl-1d3ea894fa03cc5a/out" "-L" "/home/kvark/Code/servo/target/release/build/openssl-sys-extras-8e2dc543f8892677/out" "-L" "/usr/lib64" "-L" "/usr/lib64" "-L" "/usr/lib64" "-L" "/home/kvark/Code/servo/target/release/build/tinyfiledialogs-536f92a3dc3e3c54/out" "-L" "/home/kvark/Code/servo/target/release/build/azure-2abb6fea14a91630/out/lib" "-L" "/home/kvark/Code/servo/target/release/build/servo-skia-6e927e3a35440654/out/lib" "-L" "/usr/lib64" "-L" "/usr/lib64" "-L" "/usr/lib64" "-L" "/home/kvark/Code/servo/target/release/build/fontsan-73bef34749599053/out/lib" "-L" "/home/kvark/Code/servo/target/release/build/miniz-sys-838f2a3680d67b7e/out" "-L" "/home/kvark/Code/servo/target/release/build/js-63cba1a8af57e19b/out/lib" "-L" "/home/kvark/Code/servo/target/release/build/mozjs_sys-b75999929c5a0ce6/out/js/src" "-L" "/usr/lib64" "-L" "/home/kvark/Code/servo/target/release/build/angle-52591329640ed728/out" "-L" "/home/kvark/Code/servo/target/release/build/heartbeats-simple-sys-f25f48c207ff1d45/out/lib" "-L" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-Bstatic" "-Wl,-Bdynamic" "/home/kvark/Code/servo/target/release/deps/libsig-9c07308a958a991e.rlib" "/home/kvark/Code/servo/target/release/deps/libglutin_app-dbb02442117e18a1.rlib" "/home/kvark/Code/servo/target/release/deps/libservo-f4d88043c589a21a.rlib" "/home/kvark/Code/servo/target/release/deps/libwebdriver_server-2d60f81530603933.rlib" "/home/kvark/Code/servo/target/release/deps/libdevtools-51456923a429637b.rlib" "/home/kvark/Code/servo/target/release/deps/libconstellation-227df5551e1fa62a.rlib" "/home/kvark/Code/servo/target/release/deps/libcompositing-92f00a605652258e.rlib" "/home/kvark/Code/servo/target/release/deps/libgaol-29c3320ae0f358d4.rlib" "/home/kvark/Code/servo/target/release/deps/libprofile-d0d58c17b3bea39e.rlib" "/home/kvark/Code/servo/target/release/deps/libwebrender-7f970f2d2b518a0b.rlib" "/home/kvark/Code/servo/target/release/deps/libdebugger-b56f9c4cb5f0d3fe.rlib" "/home/kvark/Code/servo/target/release/deps/libws-3cb6e80ccca3144f.rlib" "/home/kvark/Code/servo/target/release/deps/libmio-6317f7336f802844.rlib" "/home/kvark/Code/servo/target/release/deps/libmiow-def73014f4427e40.rlib" "/home/kvark/Code/servo/target/release/deps/libslab-f9a5dd7d009cfa6c.rlib" "/home/kvark/Code/servo/target/release/deps/libwebdriver-5861652241603767.rlib" "/home/kvark/Code/servo/target/release/deps/libbacktrace-4bacf46cf8f7533a.rlib" "/home/kvark/Code/servo/target/release/deps/librustc_demangle-78c6e71db8f7fb21.rlib" "/home/kvark/Code/servo/target/release/deps/libwinapi-0c6be1d302051fac.rlib" "/home/kvark/Code/servo/target/release/deps/libservo_remutex-32fbfeb30138eb24.rlib" "/home/kvark/Code/servo/target/release/deps/libglutin-2f596bd27319f5e2.rlib" "/home/kvark/Code/servo/target/release/deps/libx11_dl-f583f9205186a722.rlib" "/home/kvark/Code/servo/target/release/deps/libcanvas-48d6486a7f1c8e33.rlib" "/home/kvark/Code/servo/target/release/deps/libazure-35a21f6c7f9c1c31.rlib" "/home/kvark/Code/servo/target/release/deps/libskia-36514c3d37e968b1.rlib" "/home/kvark/Code/servo/target/release/deps/libdbghelp-fcdb1acd5531c77b.rlib" "/home/kvark/Code/servo/target/release/deps/libnix-c85ea7aed2b74f7a.rlib" "/home/kvark/Code/servo/target/release/deps/libbitflags-fcc7c58915fc1032.rlib" "/home/kvark/Code/servo/target/release/deps/liblayout_thread-1e02dfcf5f19815e.rlib" "/home/kvark/Code/servo/target/release/deps/liblayout_traits-f81a32593ddf5b05.rlib" "/home/kvark/Code/servo/target/release/deps/liblayout-17ee60a82e1c75fd.rlib" "/home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib" "/home/kvark/Code/servo/target/release/deps/libunicode_script-e8920859100674c2.rlib" "/home/kvark/Code/servo/target/release/deps/libsimd-0643530b89b6282b.rlib" "/home/kvark/Code/servo/target/release/deps/libharfbuzz_sys-7060c9c2eeb65d8f.rlib" "/home/kvark/Code/servo/target/release/deps/libfontsan-dfa181d7a7b2090a.rlib" "/home/kvark/Code/servo/target/release/deps/libbluetooth-953a460c614b6124.rlib" "/home/kvark/Code/servo/target/release/deps/libdevice-468f6ee4284ea81c.rlib" "/home/kvark/Code/servo/target/release/deps/libblurmock-06b9872d44fe065c.rlib" "/home/kvark/Code/servo/target/release/deps/libblurz-f09c50c8aaaef990.rlib" "/home/kvark/Code/servo/target/release/deps/libdbus-7810af6c308f1aec.rlib" "/home/kvark/Code/servo/target/release/deps/libnet-1eb08dd16ee5b0ff.rlib" "/home/kvark/Code/servo/target/release/deps/libthreadpool-c0be9e3c12ac627a.rlib" "/home/kvark/Code/servo/target/release/deps/libflate2-bb187df0ebb3d302.rlib" "/home/kvark/Code/servo/target/release/deps/libminiz_sys-4ffd00ce2690c0dd.rlib" "/home/kvark/Code/servo/target/release/deps/libcontent_blocker-4badc9363266c3fb.rlib" "/home/kvark/Code/servo/target/release/deps/libserde_json-5f61dbc2a6e5a997.rlib" "/home/kvark/Code/servo/target/release/deps/libdtoa-733f1fd056ac61b7.rlib" "/home/kvark/Code/servo/target/release/deps/libbrotli-27a00d7b056764ae.rlib" "/home/kvark/Code/servo/target/release/deps/liballoc_no_stdlib-2c21d3018b0342c4.rlib" "/home/kvark/Code/servo/target/release/deps/libfontconfig-3667dd7670a33abc.rlib" "/home/kvark/Code/servo/target/release/deps/libfontconfig_sys-631773be70653d57.rlib" "/home/kvark/Code/servo/target/release/deps/libexpat_sys-80cb3145e02eed4f.rlib" "/home/kvark/Code/servo/target/release/deps/libwebvr-5f5256a071b60208.rlib" "/home/kvark/Code/servo/target/release/deps/libxi_unicode-5dad805f1a6adcb9.rlib" "/home/kvark/Code/servo/target/release/deps/libkernel32-3d2d136aa6056677.rlib" "/home/kvark/Code/servo/target/release/deps/libbytes-f131f0347345226c.rlib" "/home/kvark/Code/servo/target/release/deps/libimmeta-f193ddd06ccf3584.rlib" "/home/kvark/Code/servo/target/release/deps/libarrayvec-7ffa40fe3cc21bde.rlib" "/home/kvark/Code/servo/target/release/deps/libnodrop-a494aeae17d82bdc.rlib" "/home/kvark/Code/servo/target/release/deps/libodds-f34d6ad4cc00ed0c.rlib" "/home/kvark/Code/servo/target/release/deps/libitoa-0687fdc3e3b3d1cd.rlib" "/home/kvark/Code/servo/target/release/deps/libenv_logger-488aeb6618bdfbaa.rlib" "/home/kvark/Code/servo/target/release/deps/libglx-1c0cff4fe10aa30a.rlib" "/home/kvark/Code/servo/target/release/deps/libbacktrace_sys-062a7097db91ed81.rlib" "/home/kvark/Code/servo/target/release/deps/libsha1-7db45898b436afbf.rlib" "/home/kvark/Code/servo/target/release/deps/libheartbeats_simple-f7f61d3d993eb642.rlib" "/home/kvark/Code/servo/target/release/deps/libheartbeats_simple_sys-4c238bed87751078.rlib" "/home/kvark/Code/servo/target/release/deps/libfreetype-33e107eb4ad8defe.rlib" "/home/kvark/Code/servo/target/release/deps/libfreetype_sys-1b6d3a042c19508d.rlib" "/home/kvark/Code/servo/target/release/deps/libscript-3a06982b41fdfa0e.rlib" "/home/kvark/Code/servo/target/release/deps/libxml5ever-917384fe51e874b7.rlib" "/home/kvark/Code/servo/target/release/deps/libtinyfiledialogs-737fe0bfc9369179.rlib" "/home/kvark/Code/servo/target/release/deps/libservo_rand-14ddf782ca5b2e34.rlib" "/home/kvark/Code/servo/target/release/deps/libscript_layout_interface-5b4ead0fb1906f9b.rlib" "/home/kvark/Code/servo/target/release/deps/libstyle-997618891d4ea8da.rlib" "/home/kvark/Code/servo/target/release/deps/libunicode_segmentation-2c93d3bc2087021f.rlib" "/home/kvark/Code/servo/target/release/deps/libservo_atoms-5581538e63228f6d.rlib" "/home/kvark/Code/servo/target/release/deps/libpdqsort-1669c65c931d515f.rlib" "/home/kvark/Code/servo/target/release/deps/libordered_float-36716d211d4df9b8.rlib" "/home/kvark/Code/servo/target/release/deps/libselectors-d7f15abea64db248.rlib" "/home/kvark/Code/servo/target/release/deps/libscript_traits-80f51194067c7959.rlib" "/home/kvark/Code/servo/target/release/deps/libwebvr_traits-85840dd6c751696d.rlib" "/home/kvark/Code/servo/target/release/deps/librust_webvr-2e0a05598dfaf07b.rlib" "/home/kvark/Code/servo/target/release/deps/liblibloading-847038071165d410.rlib" "/home/kvark/Code/servo/target/release/deps/libstyle_traits-6a6f13fa8d5c85a7.rlib" "/home/kvark/Code/servo/target/release/deps/libref_slice-e87b76612f0a6124.rlib" "/home/kvark/Code/servo/target/release/deps/libref_filter_map-d9d434139c3a2a14.rlib" "/home/kvark/Code/servo/target/release/deps/libprofile_traits-879513c9098de01a.rlib" "/home/kvark/Code/servo/target/release/deps/libsignpost-d37df61ce67af9ed.rlib" "/home/kvark/Code/servo/target/release/deps/libparking_lot-2daec1cec6e53970.rlib" "/home/kvark/Code/servo/target/release/deps/libparking_lot_core-c29ce49fff506c8e.rlib" "/home/kvark/Code/servo/target/release/deps/libsmallvec-5954e8b05a1f8a14.rlib" "/home/kvark/Code/servo/target/release/deps/libowning_ref-bd693ed985a69b4a.rlib" "/home/kvark/Code/servo/target/release/deps/libopen-571d30f427af26b4.rlib" "/home/kvark/Code/servo/target/release/deps/libnet_traits-842d03382b32ab6b.rlib" "/home/kvark/Code/servo/target/release/deps/libwebsocket-852c5a9908986205.rlib" "/home/kvark/Code/servo/target/release/deps/libnet2-7d75d02afcbe3933.rlib" "/home/kvark/Code/servo/target/release/deps/libcfg_if-7b736a6c4ceff9cd.rlib" "/home/kvark/Code/servo/target/release/deps/libuuid-a733e8b5710d4f3c.rlib" "/home/kvark/Code/servo/target/release/deps/libmime_guess-80edc63f525db475.rlib" "/home/kvark/Code/servo/target/release/deps/libjs-81ba2a8a61f16bee.rlib" "/home/kvark/Code/servo/target/release/deps/libmozjs_sys-0750421df0927285.rlib" "/home/kvark/Code/servo/target/release/deps/liblibz_sys-d824a81a0b5e2f21.rlib" "/home/kvark/Code/servo/target/release/deps/libimage-f352b0a2e030354a.rlib" "/home/kvark/Code/servo/target/release/deps/libscoped_threadpool-ab19788dbbcc4f07.rlib" "/home/kvark/Code/servo/target/release/deps/libgif-b8e5dddb1a0edac4.rlib" "/home/kvark/Code/servo/target/release/deps/libcolor_quant-8014b744b8f0be45.rlib" "/home/kvark/Code/servo/target/release/deps/liblzw-3a58daeb41bb83cb.rlib" "/home/kvark/Code/servo/target/release/deps/libjpeg_decoder-1cd184b0347d6260.rlib" "/home/kvark/Code/servo/target/release/deps/librayon-ee8e0f49c6cf5c2c.rlib" "/home/kvark/Code/servo/target/release/deps/libdeque-7d403b4e300ff890.rlib" "/home/kvark/Code/servo/target/release/deps/libpng-48028bf200392d9f.rlib" "/home/kvark/Code/servo/target/release/deps/libdeflate-252371fa859c2ee5.rlib" "/home/kvark/Code/servo/target/release/deps/libadler32-ea874a49a47e0a36.rlib" "/home/kvark/Code/servo/target/release/deps/libinflate-a144096bcd95dc57.rlib" "/home/kvark/Code/servo/target/release/deps/libenum_primitive-ad617ec2b5f63bf3.rlib" "/home/kvark/Code/servo/target/release/deps/libnum_rational-35b74cb862aefb15.rlib" "/home/kvark/Code/servo/target/release/deps/libnum_iter-a8834a56ca9d2c4f.rlib" "/home/kvark/Code/servo/target/release/deps/libnum_integer-526375f6a6e0fe32.rlib" "/home/kvark/Code/servo/target/release/deps/libhyper_serde-73bbbde0bc9577ca.rlib" "/home/kvark/Code/servo/target/release/deps/libhtml5ever-853b3e2007ddb189.rlib" "/home/kvark/Code/servo/target/release/deps/libtendril-cec379f8642e88b9.rlib" "/home/kvark/Code/servo/target/release/deps/libutf8-ca6f45addb8518f3.rlib" "/home/kvark/Code/servo/target/release/deps/libfutf-8a6b1a46a6f880d3.rlib" "/home/kvark/Code/servo/target/release/deps/libphf-9c68440e34fd95cf.rlib" "/home/kvark/Code/servo/target/release/deps/libmac-7bd504e940c68c68.rlib" "/home/kvark/Code/servo/target/release/deps/libhtml5ever_atoms-1e48da0e818b5a04.rlib" "/home/kvark/Code/servo/target/release/deps/libstring_cache-ab82029afedda0ee.rlib" "/home/kvark/Code/servo/target/release/deps/libstring_cache_shared-d21b17c92f17d28a.rlib" "/home/kvark/Code/servo/target/release/deps/libphf_shared-a08408531af48042.rlib" "/home/kvark/Code/servo/target/release/deps/libsiphasher-caea179fbb839004.rlib" "/home/kvark/Code/servo/target/release/deps/libdebug_unreachable-8396e371e4515150.rlib" "/home/kvark/Code/servo/target/release/deps/libgfx_traits-d2e3629dbc5cb9a3.rlib" "/home/kvark/Code/servo/target/release/deps/librange-dabe8664a1373d18.rlib" "/home/kvark/Code/servo/target/release/deps/libfnv-22b28729bb709fe1.rlib" "/home/kvark/Code/servo/target/release/deps/libdevtools_traits-4371da14f5792d5d.rlib" "/home/kvark/Code/servo/target/release/deps/libmsg-c0e334378a3f97c0.rlib" "/home/kvark/Code/servo/target/release/deps/libhyper-28d6da5453721393.rlib" "/home/kvark/Code/servo/target/release/deps/libmime-b3681d946f687875.rlib" "/home/kvark/Code/servo/target/release/deps/liblanguage_tags-aa5a1721eca7257c.rlib" "/home/kvark/Code/servo/target/release/deps/libsolicit-d9747a6ca80bc882.rlib" "/home/kvark/Code/servo/target/release/deps/libhpack-2091ad2174623cf5.rlib" "/home/kvark/Code/servo/target/release/deps/libtypeable-b641216075999a77.rlib" "/home/kvark/Code/servo/target/release/deps/libtraitobject-d5c6254b033d46b2.rlib" "/home/kvark/Code/servo/target/release/deps/libhttparse-57297fe16e170827.rlib" "/home/kvark/Code/servo/target/release/deps/libunicase-ea60fd41c461d13d.rlib" "/home/kvark/Code/servo/target/release/deps/libopenssl_verify-6811ad1dc9663b3f.rlib" "/home/kvark/Code/servo/target/release/deps/libcookie-f3409e4a7ab78387.rlib" "/home/kvark/Code/servo/target/release/deps/libopenssl-a6d93a958d5f269f.rlib" "/home/kvark/Code/servo/target/release/deps/libopenssl_sys_extras-cbc49b03f51826d6.rlib" "/home/kvark/Code/servo/target/release/deps/libopenssl_sys-eb1d0cb4321a0c87.rlib" "/home/kvark/Code/servo/target/release/deps/libtime-df5cd87a59faaef1.rlib" "/home/kvark/Code/servo/target/release/deps/libcaseless-1679ee10eb70324c.rlib" "/home/kvark/Code/servo/target/release/deps/libcanvas_traits-ccf48ff00e40ad8b.rlib" "/home/kvark/Code/servo/target/release/deps/libwebrender_traits-f8c00ff399b62ee2.rlib" "/home/kvark/Code/servo/target/release/deps/liboffscreen_gl_context-f37c38a9374fd700.rlib" "/home/kvark/Code/servo/target/release/deps/libosmesa_sys-3277402bc8817e34.rlib" "/home/kvark/Code/servo/target/release/deps/libshared_library-d27870c0f1106144.rlib" "/home/kvark/Code/servo/target/release/deps/libx11-a39585556a176815.rlib" "/home/kvark/Code/servo/target/release/deps/libgleam-868b4ec273e2741c.rlib" "/home/kvark/Code/servo/target/release/deps/libcssparser-887286580fa41709.rlib" "/home/kvark/Code/servo/target/release/deps/libbluetooth_traits-4af410e950be9e9b.rlib" "/home/kvark/Code/servo/target/release/deps/libservo_config-38891432c05f45f5.rlib" "/home/kvark/Code/servo/target/release/deps/libxdg-1f46720c46440d97.rlib" "/home/kvark/Code/servo/target/release/deps/libservo_url-eb34604a03f4e9cb.rlib" "/home/kvark/Code/servo/target/release/deps/liburl-1e8fdb11f9507569.rlib" "/home/kvark/Code/servo/target/release/deps/libencoding-8fc980a2e2ef335a.rlib" "/home/kvark/Code/servo/target/release/deps/libencoding_index_tradchinese-5d147a0bef597104.rlib" "/home/kvark/Code/servo/target/release/deps/libencoding_index_simpchinese-ed831c6d09635f8d.rlib" "/home/kvark/Code/servo/target/release/deps/libencoding_index_japanese-bd999813fb6599d8.rlib" "/home/kvark/Code/servo/target/release/deps/libencoding_index_korean-4c8061c5467ae701.rlib" "/home/kvark/Code/servo/target/release/deps/libencoding_index_singlebyte-b87a3a1dbef4c20e.rlib" "/home/kvark/Code/servo/target/release/deps/libidna-3470bd64de4f9910.rlib" "/home/kvark/Code/servo/target/release/deps/libunicode_normalization-86787806df218c28.rlib" "/home/kvark/Code/servo/target/release/deps/libunicode_bidi-ede9d4430659f041.rlib" "/home/kvark/Code/servo/target/release/deps/libmatches-3bb6e7f56ca2dd49.rlib" "/home/kvark/Code/servo/target/release/deps/libservo_geometry-27de3def8783b0ac.rlib" "/home/kvark/Code/servo/target/release/deps/libnum_cpus-6f66f759994faf59.rlib" "/home/kvark/Code/servo/target/release/deps/libgetopts-76f4457fad24783c.rlib" "/home/kvark/Code/servo/target/release/deps/libeuclid-ff9105d27b45c468.rlib" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib/libtest-c268df46a455da2e.rlib" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib/libterm-3b032f1a18504e83.rlib" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgetopts-9f0027fbffa38971.rlib" "/home/kvark/Code/servo/target/release/deps/liblog-8d564d26f103b716.rlib" "/home/kvark/Code/servo/target/release/deps/libregex-dda931532bb7f1f2.rlib" "/home/kvark/Code/servo/target/release/deps/libutf8_ranges-ac45e277014bbc8a.rlib" "/home/kvark/Code/servo/target/release/deps/libregex_syntax-12d9d8a01c3721ae.rlib" "/home/kvark/Code/servo/target/release/deps/libthread_local-19c1a01fc95c9d3c.rlib" "/home/kvark/Code/servo/target/release/deps/libunreachable-f2df520df003302b.rlib" "/home/kvark/Code/servo/target/release/deps/libvoid-3b27c16b349b6be3.rlib" "/home/kvark/Code/servo/target/release/deps/libthread_id-b435187b8da15af4.rlib" "/home/kvark/Code/servo/target/release/deps/libaho_corasick-650f2c49bb060751.rlib" "/home/kvark/Code/servo/target/release/deps/libmemchr-b06a40b595d0bf3e.rlib" "/home/kvark/Code/servo/target/release/deps/libipc_channel-1f5e713794462234.rlib" "/home/kvark/Code/servo/target/release/deps/librand-edb078ba7b4b5548.rlib" "/home/kvark/Code/servo/target/release/deps/libbincode-21922262191666b2.rlib" "/home/kvark/Code/servo/target/release/deps/libbyteorder-30acb91327072c30.rlib" "/home/kvark/Code/servo/target/release/deps/liblazy_static-9437d900739939e6.rlib" "/home/kvark/Code/servo/target/release/deps/libbitflags-03d2f8fc1bd339bd.rlib" "/home/kvark/Code/servo/target/release/deps/libaudio_video_metadata-45e9caf2b78990b0.rlib" "/home/kvark/Code/servo/target/release/deps/libogg_metadata-a0ed55018327d812.rlib" "/home/kvark/Code/servo/target/release/deps/libogg-f40b3942b34405a5.rlib" "/home/kvark/Code/servo/target/release/deps/libmp4parse-5efb43311ac22400.rlib" "/home/kvark/Code/servo/target/release/deps/libbyteorder-d4fa08dc3f59cc73.rlib" "/home/kvark/Code/servo/target/release/deps/libmp3_metadata-269fb8cef12c8524.rlib" "/home/kvark/Code/servo/target/release/deps/libatomic_refcell-b6af43d59f30eaf2.rlib" "/home/kvark/Code/servo/target/release/deps/libapp_units-36d342be642a9589.rlib" "/home/kvark/Code/servo/target/release/deps/libserde-511d1c3718c7ad6a.rlib" "/home/kvark/Code/servo/target/release/deps/librustc_serialize-bd7ffb5a7ba50190.rlib" "/home/kvark/Code/servo/target/release/deps/libnum_traits-9e0712891cb84422.rlib" "/home/kvark/Code/servo/target/release/deps/libheapsize-c68cae123b8e35ba.rlib" "/home/kvark/Code/servo/target/release/deps/libangle-e77045f2d1c1caaa.rlib" "/home/kvark/Code/servo/target/release/deps/liblibc-e8bd7a8d60e9ed01.rlib" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-93390f7535a2b2f7.rlib" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib/libpanic_unwind-277781e5e83f4ddf.rlib" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib/libunwind-9fb0680200b1f1d7.rlib" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib/librand-8fe8e03da90d4fd4.rlib" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcollections-91e6e43d741825a3.rlib" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc-91c6f0edecc68d05.rlib" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_jemalloc-3e3384d4e8c6562d.rlib" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblibc-552ce29795ce9c9d.rlib" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd_unicode-e19b6c0e5bf50406.rlib" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-c1ab5423a7223378.rlib" "/home/kvark/Code/servo/.servo/rust/2017-02-05/rustc-nightly-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-5d4fca8590bb0079.rlib" "-l" "dl" "-l" "skia" "-l" "GL" "-l" "stdc++" "-l" "freetype" "-l" "bz2" "-l" "fontconfig" "-l" "expat" "-l" "X11" "-l" "azure" "-l" "stdc++" "-l" "bz2" "-l" "GL" "-l" "harfbuzz" "-l" "stdc++" "-l" "dbus-1" "-l" "fontconfig" "-l" "freetype" "-l" "expat" "-l" "freetype" "-l" "dl" "-l" "stdc++" "-l" "z" "-l" "ssl" "-l" "crypto" "-l" "X11" "-l" "GL" "-l" "stdc++" "-l" "util" "-l" "dl" "-l" "rt" "-l" "pthread" "-l" "gcc_s" "-l" "pthread" "-l" "c" "-l" "m" "-l" "rt" "-l" "util" "-fuse-ld=gold"
  = note: /usr/bin/ld.gold: error: cannot find -lharfbuzz
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function std::sync::once::Once::call_once::_$u7b$$u7b$closure$u7d$$u7d$::h6cd1278f8e4e0740: error: undefined reference to 'hb_font_funcs_create'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function std::sync::once::Once::call_once::_$u7b$$u7b$closure$u7d$$u7d$::h6cd1278f8e4e0740: error: undefined reference to 'hb_font_funcs_set_glyph_func'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function std::sync::once::Once::call_once::_$u7b$$u7b$closure$u7d$$u7d$::h6cd1278f8e4e0740: error: undefined reference to 'hb_font_funcs_set_glyph_h_advance_func'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function std::sync::once::Once::call_once::_$u7b$$u7b$closure$u7d$$u7d$::h6cd1278f8e4e0740: error: undefined reference to 'hb_font_funcs_set_glyph_h_kerning_func'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function drop::h1f0bdcd5c5414697: error: undefined reference to 'hb_face_destroy'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function drop::h1f0bdcd5c5414697: error: undefined reference to 'hb_font_destroy'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function gfx::font::Font::shape_text::h888210ee53131351: error: undefined reference to 'hb_face_destroy'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function gfx::font::Font::shape_text::h888210ee53131351: error: undefined reference to 'hb_font_destroy'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function gfx::font::Font::shape_text::h888210ee53131351: error: undefined reference to 'hb_face_destroy'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function gfx::font::Font::shape_text::h888210ee53131351: error: undefined reference to 'hb_font_destroy'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function _$LT$gfx..text..shaping..harfbuzz..Shaper$u20$as$u20$core..ops..Drop$GT$::drop::hb75280a17014fd8d: error: undefined reference to 'hb_face_destroy'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function _$LT$gfx..text..shaping..harfbuzz..Shaper$u20$as$u20$core..ops..Drop$GT$::drop::hb75280a17014fd8d: error: undefined reference to 'hb_font_destroy'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function gfx::text::shaping::harfbuzz::Shaper::new::h79c17421835f9de9: error: undefined reference to 'hb_face_create_for_tables'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function gfx::text::shaping::harfbuzz::Shaper::new::h79c17421835f9de9: error: undefined reference to 'hb_font_create'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function gfx::text::shaping::harfbuzz::Shaper::new::h79c17421835f9de9: error: undefined reference to 'hb_font_set_ppem'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function gfx::text::shaping::harfbuzz::Shaper::new::h79c17421835f9de9: error: undefined reference to 'hb_font_set_scale'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function gfx::text::shaping::harfbuzz::Shaper::new::h79c17421835f9de9: error: undefined reference to 'hb_font_set_funcs'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function _$LT$gfx..text..shaping..harfbuzz..Shaper$u20$as$u20$gfx..text..shaping..ShaperMethods$GT$::shape_text::h9d86eb0eff2d248a: error: undefined reference to 'hb_buffer_create'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function _$LT$gfx..text..shaping..harfbuzz..Shaper$u20$as$u20$gfx..text..shaping..ShaperMethods$GT$::shape_text::h9d86eb0eff2d248a: error: undefined reference to 'hb_buffer_set_direction'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function _$LT$gfx..text..shaping..harfbuzz..Shaper$u20$as$u20$gfx..text..shaping..ShaperMethods$GT$::shape_text::h9d86eb0eff2d248a: error: undefined reference to 'hb_buffer_set_script'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function _$LT$gfx..text..shaping..harfbuzz..Shaper$u20$as$u20$gfx..text..shaping..ShaperMethods$GT$::shape_text::h9d86eb0eff2d248a: error: undefined reference to 'hb_buffer_add_utf8'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function _$LT$gfx..text..shaping..harfbuzz..Shaper$u20$as$u20$gfx..text..shaping..ShaperMethods$GT$::shape_text::h9d86eb0eff2d248a: error: undefined reference to 'hb_buffer_get_length'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function _$LT$gfx..text..shaping..harfbuzz..Shaper$u20$as$u20$gfx..text..shaping..ShaperMethods$GT$::shape_text::h9d86eb0eff2d248a: error: undefined reference to 'hb_buffer_get_length'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function _$LT$gfx..text..shaping..harfbuzz..Shaper$u20$as$u20$gfx..text..shaping..ShaperMethods$GT$::shape_text::h9d86eb0eff2d248a: error: undefined reference to 'hb_shape'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function _$LT$gfx..text..shaping..harfbuzz..Shaper$u20$as$u20$gfx..text..shaping..ShaperMethods$GT$::shape_text::h9d86eb0eff2d248a: error: undefined reference to 'hb_buffer_get_glyph_infos'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function _$LT$gfx..text..shaping..harfbuzz..Shaper$u20$as$u20$gfx..text..shaping..ShaperMethods$GT$::shape_text::h9d86eb0eff2d248a: error: undefined reference to 'hb_buffer_get_glyph_positions'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function _$LT$gfx..text..shaping..harfbuzz..Shaper$u20$as$u20$gfx..text..shaping..ShaperMethods$GT$::shape_text::h9d86eb0eff2d248a: error: undefined reference to 'hb_buffer_destroy'
          /home/kvark/Code/servo/target/release/deps/libgfx-29f1c95ba4cad766.rlib(gfx-29f1c95ba4cad766.0.o):gfx.cgu-0.rs:function gfx::text::shaping::harfbuzz::font_table_func::hc877a545b8613d69: error: undefined reference to 'hb_blob_create'
          /home/kvark/Code/servo/target/release/deps/libipc_channel-1f5e713794462234.rlib(ipc_channel-1f5e713794462234.0.o):ipc_channel.cgu-0.rs:function ipc_channel::platform::os::OsIpcOneShotServer::new::ha845fb3730c8f25d: warning: the use of `mktemp' is dangerous, better use `mkstemp' or `mkdtemp'
          collect2: error: ld returned 1 exit status
          

error: aborting due to previous error

error: Could not compile `servo`.

To learn more, run the command again with --verbose.
Build FAILED in 0:23:28

[asajeffrey]

Hmm, you appear not to have the harfbuzz lib in your load path. What does ls ./target/release/build/harfbuzz-sys-*/out/lib show? Does ./mach clean before ./mach build help?

[kvark]

@asajeffrey ls shows several harfbuzz-sys-*/out folders, all empty
Doing ./mach clean before the build, then building seems to produce a different error:

cd /home/kvark/Code/servo/target/release/build/harfbuzz-sys-d43185f8328d1583/out && make -j4
make[1]: Entering directory '/home/kvark/Code/servo/target/release/build/harfbuzz-sys-d43185f8328d1583/out'
CDPATH="${ZSH_VERSION+.}:" && cd /home/kvark/Code/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/harfbuzz-sys-0.1.7/harfbuzz && /bin/sh /home/kvark/Code/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/harfbuzz-sys-0.1.7/harfbuzz/missing aclocal-1.14 -I m4
Makefile:451: recipe for target '/home/kvark/Code/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/harfbuzz-sys-0.1.7/harfbuzz/aclocal.m4' failed
make[1]: Leaving directory '/home/kvark/Code/servo/target/release/build/harfbuzz-sys-d43185f8328d1583/out'
makefile.cargo:35: recipe for target 'all' failed

--- stderr
configure: WARNING:
  You will not be able to create source packages with 'make dist'
  because gtk-doc >= 1.15 is not found.
make[1]: warning: -jN forced in submake: disabling jobserver mode.
/home/kvark/Code/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/harfbuzz-sys-0.1.7/harfbuzz/missing: line 81: aclocal-1.14: command not found
WARNING: 'aclocal-1.14' is missing on your system.
         You should only need it if you modified 'acinclude.m4' or
         'configure.ac' or m4 files included by 'configure.ac'.
         The 'aclocal' program is part of the GNU Automake package:
         <http://www.gnu.org/software/automake>
         It also requires GNU Autoconf, GNU m4 and Perl in order to run:
         <http://www.gnu.org/software/autoconf>
         <http://www.gnu.org/software/m4/>
         <http://www.perl.org/>
make[1]: *** [/home/kvark/Code/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/harfbuzz-sys-0.1.7/harfbuzz/aclocal.m4] Error 127
make: *** [all] Error 2
thread 'main' panicked at 'assertion failed: Command::new("make").args(&["-R", "-f", "makefile.cargo",
                            &format!("-j{}" , env :: var ( "NUM_JOBS" ) .
                                     unwrap (
                                     ))]).status().unwrap().success()', /home/kvark/Code/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/harfbuzz-sys-0.1.7/build.rs:24
note: Run with `RUST_BACKTRACE=1` for a backtrace.

TL;DR: "gtk-doc >= 1.15 is not found"

[jdm]

That looks like aclocal-1.14 is missing; the gtk-doc thing is just a warning about make dist not being possible.

[kvark]

@jdm

[kvark@carbon servo]$ aclocal --version
aclocal (GNU automake) 1.15

[jdm]

Right, but it wants aclocal-1.14.

[asajeffrey]

It looks like this issue is caused by the fact that we are vendoring the generated aclocal.m4 file, which is specific to the version of aclocal it was build with. In the upstream harfbuzz (https://github.com/behdad/harfbuzz) the aclocal.m4 file isn't checked in, it's generated by ./configure. We're building harfbuzz from make rather than from configure: https://github.com/servo/rust-harfbuzz/blob/5ce21099efcc2b59c0586ce5f7d7a0b66ac5c716/harfbuzz-sys/build.rs#L24.

Installing harfbuzz-devel is a work-around, since it uses the system harfbuzz rather than building it.

[kvark]

@asajeffrey so I guess this PR should be closed, and you guys can open a separate issue to fix the vendored harfbuzz version. Thanks for looking into it!

[asajeffrey]

See servo/rust-harfbuzz#54

[asajeffrey]

cc @mbrubeck

[kvark]

@asajeffrey that issue is closed, which seems wrong to me

[asajeffrey]

Yes, we may need to reopen it.