Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rustc-serialize from range #15515

Merged
merged 2 commits into from Feb 12, 2017
Merged

Remove rustc-serialize from range #15515

merged 2 commits into from Feb 12, 2017

Conversation

@nox
Copy link
Member

nox commented Feb 12, 2017 •
edited by larsbergstrom

This change is Reviewable
nox added 2 commits Feb 12, 2017
@nox
Kill dead code
5aba878
@nox
Remove rustc-serialize from range
Loading status checks…
58046cc
@highfive
Copy link

highfive commented Feb 12, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/bindings/conversions.rs
  • @KiChjang: components/script/dom/bindings/conversions.rs
@highfive
Copy link

highfive commented Feb 12, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Feb 12, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 12, 2017

📌 Commit 58046cc has been approved by jdm
@highfive highfive assigned jdm and unassigned Manishearth Feb 12, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Feb 12, 2017

⌛ Testing commit 58046cc with merge 89dcbec...
bors-servo added a commit that referenced this pull request Feb 12, 2017
@bors-servo
Auto merge of #15515 - nox:rustc-serialize, r=jdm
Loading status checks…
89dcbec 
Remove rustc-serialize from range

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15515)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 12, 2017

💔 Test failed - mac-rel-css
@jdm
Copy link
Member

jdm commented Feb 12, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 12, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 12, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: jdm
Pushing 89dcbec to master...
@bors-servo bors-servo merged commit 58046cc into servo:master Feb 12, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Feb 12, 2017
Merged
4 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @jdm @bors-servo @Manishearth
You can’t perform that action at this time.