Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstyle: Unbox a bunch of color properties. #15518
Merged
Conversation
highfive
commented
Feb 12, 2017
|
Heads up! This PR modifies the following files:
|
|
r? @SimonSapin |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Feb 12, 2017
style: Unbox a bunch of color properties. This builds on servo/rust-cssparser#118. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15518) <!-- Reviewable:end -->
|
|
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Feb 12, 2017
style: Unbox a bunch of color properties. This builds on servo/rust-cssparser#118. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15518) <!-- Reviewable:end -->
|
|
|
The linux builder suddenly does not like osmesa, apparently :< |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Feb 13, 2017
style: Unbox a bunch of color properties. This builds on servo/rust-cssparser#118. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15518) <!-- Reviewable:end -->
|
|
|
@bors-servo try |
|
Ouch, these are legit, even though I believe we should be using the stored value? huh. |
|
Of course those properties still use |
|
Hhmm... Or maybe I'm wrong, huh |
|
The reason this works in Gecko: http://searchfox.org/mozilla-central/source/layout/style/nsStyleUtil.cpp#702 |
|
@SimonSapin, Gecko rounds |
|
Interesting. I do think we should copy Gecko’s behavior of rounding to 2 decimal digits if that round-trips to the same |
|
To be clear, the above is only for serialization, not for gfx APIs that use floats. |
|
Sure, makes sense |
|
@bors-servo try |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Feb 14, 2017
style: Unbox a bunch of color properties. This builds on servo/rust-cssparser#118. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15518) <!-- Reviewable:end -->
|
|
|
|
That is #14323, the rest seems green |
This builds on servo/rust-cssparser#118.
|
@bors-servo r+ Reviewed 19 of 19 files at r4. Comments from Reviewable |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 14, 2017
style: Unbox a bunch of color properties. This builds on servo/rust-cssparser#118. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15518) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedFeb 12, 2017
•
edited by larsbergstrom
This builds on servo/rust-cssparser#118.
This change is