Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement `selectedIndex` IDL attribute on `HTMLOptionsCollection`. #15520

Merged
merged 1 commit into from Feb 19, 2017
Merged

Implement `selectedIndex` IDL attribute on `HTMLOptionsCollection`. #15520

merged 1 commit into from Feb 19, 2017
+65 −24

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Feb 13, 2017 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Feb 13, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/webidls/HTMLOptionsCollection.webidl, components/script/dom/htmloptionscollection.rs
  • @KiChjang: components/script/dom/webidls/HTMLOptionsCollection.webidl, components/script/dom/htmloptionscollection.rs
@highfive
Copy link

highfive commented Feb 13, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@frewsxcv
Copy link
Member Author

frewsxcv commented Feb 13, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2017

⌛ Trying commit 2a70d5b with merge 7d6d55b...
bors-servo added a commit that referenced this pull request Feb 13, 2017
@bors-servo
Auto merge of #15520 - frewsxcv:html-options-collection-selected-inde…
Loading status checks…
7d6d55b 
…x, r=<try>

Implement `selectedIndex` IDL attribute on `HTMLOptionsCollection`.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15520)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2017

💔 Test failed - linux-rel-wpt
@frewsxcv frewsxcv force-pushed the frewsxcv:html-options-collection-selected-index branch from 2a70d5b to 18d119e Feb 13, 2017
@frewsxcv
Copy link
Member Author

frewsxcv commented Feb 13, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2017

⌛ Trying commit 18d119e with merge 6e35971...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2017

💔 Test failed - mac-dev-unit
@frewsxcv frewsxcv force-pushed the frewsxcv:html-options-collection-selected-index branch from 18d119e to ce3ba8f Feb 13, 2017
@frewsxcv
Copy link
Member Author

frewsxcv commented Feb 13, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2017

⌛ Trying commit ce3ba8f with merge e454261...
bors-servo added a commit that referenced this pull request Feb 13, 2017
@bors-servo
Auto merge of #15520 - frewsxcv:html-options-collection-selected-inde…
Loading status checks…
e454261 
…x, r=<try>

Implement `selectedIndex` IDL attribute on `HTMLOptionsCollection`.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15520)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2017

💔 Test failed - mac-rel-wpt1
@frewsxcv frewsxcv requested review from Ms2ger and nox Feb 13, 2017
@frewsxcv
Implement `selectedIndex` IDL attribute on `HTMLOptionsCollection`.
Loading status checks…
d4ad51b
@frewsxcv frewsxcv force-pushed the frewsxcv:html-options-collection-selected-index branch from ce3ba8f to d4ad51b Feb 13, 2017
@frewsxcv
Copy link
Member Author

frewsxcv commented Feb 13, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2017

⌛ Trying commit d4ad51b with merge e5d3777...
bors-servo added a commit that referenced this pull request Feb 13, 2017
@bors-servo
Auto merge of #15520 - frewsxcv:html-options-collection-selected-inde…
Loading status checks…
e5d3777 
…x, r=<try>

Implement `selectedIndex` IDL attribute on `HTMLOptionsCollection`.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15520)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2017

💥 Test timed out
@frewsxcv
Copy link
Member Author

frewsxcv commented Feb 15, 2017

@bors-servo try
@jdm
Copy link
Member

jdm commented Feb 15, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2017

⌛ Trying commit d4ad51b with merge 6359420...
bors-servo added a commit that referenced this pull request Feb 15, 2017
@bors-servo
Auto merge of #15520 - frewsxcv:html-options-collection-selected-inde…
Loading status checks…
6359420 
…x, r=<try>

Implement `selectedIndex` IDL attribute on `HTMLOptionsCollection`.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15520)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
State: approved= try=True
@nox
nox approved these changes Feb 15, 2017
View changes
@nox
Copy link
Member

nox commented Feb 15, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2017

📌 Commit d4ad51b has been approved by nox
@highfive highfive assigned nox and unassigned metajack Feb 15, 2017
@Manishearth
Copy link
Member

Manishearth commented Feb 15, 2017

@bors-servo r=nox , please
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #15545
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2017

📌 Commit d4ad51b has been approved by nox
@Manishearth
Copy link
Member

Manishearth commented Feb 15, 2017

@bors-servo try- r=nox retry
@nox
Copy link
Member

nox commented Feb 19, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2017

💡 This pull request was already approved, no need to approve it again.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2017

📌 Commit d4ad51b has been approved by nox
@nox
Copy link
Member

nox commented Feb 19, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2017

⌛ Testing commit d4ad51b with merge 5f81323...
bors-servo added a commit that referenced this pull request Feb 19, 2017
@bors-servo
Auto merge of #15520 - frewsxcv:html-options-collection-selected-inde…
Loading status checks…
5f81323 
…x, r=nox

Implement `selectedIndex` IDL attribute on `HTMLOptionsCollection`.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15520)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: nox
Pushing 5f81323 to master...
@bors-servo bors-servo merged commit d4ad51b into servo:master Feb 19, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:html-options-collection-selected-index branch Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nox nox

@Ms2ger Ms2ger

Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@frewsxcv @highfive @bors-servo @jdm @nox @Manishearth @metajack
You can’t perform that action at this time.