Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate ipc-channel to 0.6.3 #15537
Update ipc-channel to 0.6.3 #15537
Conversation
highfive
commented
Feb 14, 2017
|
Heads up! This PR modifies the following files:
|
|
@bors-servo try |
|
@bors-servo are you still there? |
|
@bors-servo try |
|
@bors-servo try |
Update ipc-channel to 0.6.1 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15537) <!-- Reviewable:end -->
|
|
|
|
|
r=me on the first two commits. Reviewed 26 of 26 files at r2. Comments from Reviewable |
|
@bors-servo try |
Update ipc-channel to 0.6.1 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15537) <!-- Reviewable:end -->
|
Reviewed 29 of 29 files at r4. Comments from Reviewable |
|
|
|
@antrik Seems like IPC is busted, did you ever see this?
```
/eventsource/eventsource-cross-origin.htm
/eventsource/request-cache-control.htm Ran 59 tests finished in 18.0 seconds. Tests with unexpected results:
|
|
In ipc-channel:
|
|
Cc @danlrobertson |
|
r=me without the WIP commit. Reviewed 29 of 29 files at r5, 30 of 30 files at r6. servo-tidy.toml, line 34 at r6 (raw file):
:( Comments from Reviewable |
|
|
|
@bors-servo try I Git bad. |
Update ipc-channel to 0.6.3 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15537) <!-- Reviewable:end -->
|
|
|
@bors-servo r=SimonSapin |
|
|
|
@bors-servo p=7 |
Update ipc-channel to 0.6.3 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15537) <!-- Reviewable:end -->
|
|

nox commentedFeb 14, 2017
•
edited by larsbergstrom
This change is