Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDerive DomObject with a proc macro #15543
Conversation
highfive
commented
Feb 14, 2017
highfive
commented
Feb 14, 2017
|
Reviewed 9 of 9 files at r1. components/domobject_derive/lib.rs, line 41 at r1 (raw file):
Change this to a fully qualified call? Comments from Reviewable |
|
A trait is always imported in itself, so it's not a problem to not fully-qualify that. @bors-servo r=SimonSapin |
|
|
Derive DomObject with a proc macro <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15543) <!-- Reviewable:end -->
|
|
I think we should still do this, to ensure that it is indeed a |
|
AFAIK it won't compile when it could be ambiguous.
|
nox commentedFeb 14, 2017
•
edited by larsbergstrom
This change is