Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate cssparser to 0.9 #15552
Merged
Update cssparser to 0.9 #15552
+72
−82
Conversation
highfive
commented
Feb 14, 2017
|
@bors-servo try |
highfive
commented
Feb 14, 2017
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 14, 2017
Do not merge yet: Update cssparser to 0.9 <!-- Please describe your changes on the following line: --> Do not merge yet. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
Tidy fails because of |
SimonSapin
changed the title
|
This is now ready to land. r? @Manishearth |
|
r=me with that one super nit. |
tests/unit/stylo/Cargo.toml
Outdated
| @@ -14,7 +14,7 @@ doctest = false | |||
| [dependencies] | |||
| app_units = "0.3" | |||
| atomic_refcell = "0.1" | |||
| cssparser = {version = "0.8"} | |||
| cssparser = {version = "0.9"} | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=nox |
|
|
|
|
|
|
|
@bors-servo r=nox |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2017
Update cssparser to 0.9 <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15552) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedFeb 14, 2017
•
edited
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is