Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update js. #15563

Merged
merged 1 commit into from Feb 15, 2017
Merged

Update js. #15563

merged 1 commit into from Feb 15, 2017

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 15, 2017 •
edited by larsbergstrom

Fixes #15553.

This change is Reviewable
@highfive
Copy link

highfive commented Feb 15, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/vreyeparameters.rs, components/script/dom/vrframedata.rs, components/script/dom/textencoder.rs, components/script/dom/vrpose.rs, components/script/dom/imagedata.rs, components/script/dom/filereader.rs, components/script/dom/websocket.rs, components/script/dom/vrstageparameters.rs
  • @KiChjang: components/script/dom/vreyeparameters.rs, components/script/dom/vrframedata.rs, components/script/dom/textencoder.rs, components/script/dom/vrpose.rs, components/script/dom/imagedata.rs, components/script/dom/filereader.rs, components/script/dom/websocket.rs, components/script/dom/vrstageparameters.rs
@highfive
Copy link

highfive commented Feb 15, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@emilio
emilio approved these changes Feb 15, 2017
View changes
Copy link
Member

emilio left a comment

r=me, I'd appreciate you answering my question though.
components/script/dom/vrstageparameters.rs
@@ -33,10 +33,10 @@ impl VRStageParameters {
parameters: DOMRefCell::new(parameters),
transform: Heap::default()
};
// XXX unsound!

This comment has been minimized.

Sign in to view
@emilio

emilio Feb 15, 2017

Member

Just to check, since it wasn't obvious to me. This is unsound because VRStageParameters is unrooted, so transform is not rooted too, right?

This comment has been minimized.

Sign in to view
@Ms2ger

Ms2ger Feb 15, 2017

Author Contributor

Yep
@emilio
Copy link
Member

emilio commented Feb 15, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2017

📌 Commit b69cacd has been approved by emilio
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 15, 2017

@bors-servo p=10
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2017

⌛ Testing commit b69cacd with merge ac76559...
bors-servo added a commit that referenced this pull request Feb 15, 2017
@bors-servo
Auto merge of #15563 - servo:update-js, r=emilio
Loading status checks…
ac76559 
Update js.

Fixes #15553.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15563)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2017

💔 Test failed - mac-rel-wpt1
@Ms2ger
Update js.
Loading status checks…
67c572a 
Fixes #15553.
@Ms2ger Ms2ger force-pushed the update-js branch from b69cacd to 67c572a Feb 15, 2017
@nox
Copy link
Member

nox commented Feb 15, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2017

📌 Commit 67c572a has been approved by nox
@highfive highfive assigned nox and unassigned emilio Feb 15, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2017

⌛ Testing commit 67c572a with merge 34fb10b...
bors-servo added a commit that referenced this pull request Feb 15, 2017
@bors-servo
Auto merge of #15563 - servo:update-js, r=nox
Loading status checks…
34fb10b 
Update js.

Fixes #15553.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15563)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: nox
Pushing 34fb10b to master...
@bors-servo bors-servo merged commit 67c572a into master Feb 15, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Feb 15, 2017
Merged
@SimonSapin SimonSapin deleted the update-js branch Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @emilio @bors-servo @nox
You can’t perform that action at this time.