Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Implement 'align-self' and 'justify-self' #15576

Merged
merged 1 commit into from Feb 16, 2017
Merged

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Feb 15, 2017

Stylo-only patch to match Gecko property support. Part of #15001. r? @Manishearth


This change is Reviewable

@highfive
Copy link

highfive commented Feb 15, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/values/specified/mod.rs, components/style/values/computed/mod.rs, components/style/properties/longhand/position.mako.rs, components/style/values/specified/align.rs
  • @emilio: components/style/properties/gecko.mako.rs, components/style/values/specified/mod.rs, components/style/values/computed/mod.rs, components/style/properties/longhand/position.mako.rs, components/style/values/specified/align.rs
@highfive
Copy link

highfive commented Feb 15, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
Copy link
Member

Manishearth left a comment

r=me

///
/// https://drafts.csswg.org/css-align/#self-alignment
#[derive(Copy, Clone, Debug, Eq, PartialEq)]
pub struct AlignJustifySelf {

This comment has been minimized.

@Manishearth

Manishearth Feb 16, 2017

Member

nit: prefer a tuple struct for this

This comment has been minimized.

@mbrubeck

mbrubeck Feb 16, 2017

Author Contributor

Fixed.

@mbrubeck mbrubeck force-pushed the mbrubeck:align branch from a61dd9a to b45e17f Feb 16, 2017
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Feb 16, 2017

@bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

📌 Commit b45e17f has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

Testing commit b45e17f with merge 75a5d10...

bors-servo added a commit that referenced this pull request Feb 16, 2017
stylo: Implement 'align-self' and 'justify-self'

Stylo-only patch to match Gecko property support. Part of #15001. r? @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15576)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

💔 Test failed - mac-dev-unit

@mbrubeck mbrubeck force-pushed the mbrubeck:align branch from b45e17f to 4de480e Feb 16, 2017
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Feb 16, 2017

@bors-servo r=Manishearth

  • Changed conditional compilation to work right for unit tests
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

📌 Commit 4de480e has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

Testing commit 4de480e with merge 11396b4...

bors-servo added a commit that referenced this pull request Feb 16, 2017
stylo: Implement 'align-self' and 'justify-self'

Stylo-only patch to match Gecko property support. Part of #15001. r? @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15576)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: Manishearth
Pushing 11396b4 to master...

@bors-servo bors-servo merged commit 4de480e into servo:master Feb 16, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck mbrubeck deleted the mbrubeck:align branch May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.