Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindgenup #15580

Merged
merged 1 commit into from Feb 16, 2017
Merged

Bindgenup #15580

merged 1 commit into from Feb 16, 2017

Conversation

@emilio
Copy link
Member

emilio commented Feb 16, 2017 •
edited by larsbergstrom

Major pain point is that I had to write the bitfield stuff manually, but that
should be resolved soon again.

Now we generate proper layout for every struct, including field offsets \o/.

r? @heycam

This change is Reviewable
@emilio
Bindgenup
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
91e0ae2 
Major pain point is that I had to write the bitfield stuff manually, but that
should be resolved soon again.

Now we generate proper layout for _every_ struct, including field offsets \o/.
@highfive
Copy link

highfive commented Feb 16, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, components/style/gecko_string_cache/mod.rs, components/style/gecko_bindings/structs_release.rs, components/style/gecko_string_cache/atom_macro.rs
@highfive
Copy link

highfive commented Feb 16, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@heycam
Copy link
Member

heycam commented Feb 16, 2017

@bors-servo r+

Hooray for correct layout with bitfields! :)
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

📌 Commit 91e0ae2 has been approved by heycam
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

⌛ Testing commit 91e0ae2 with merge c66ad00...
bors-servo added a commit that referenced this pull request Feb 16, 2017
@bors-servo
Auto merge of #15580 - emilio:stylo, r=heycam
Loading status checks…
c66ad00 
Bindgenup

Major pain point is that I had to write the bitfield stuff manually, but that
should be resolved soon again.

Now we generate proper layout for _every_ struct, including field offsets \o/.

r? @heycam

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15580)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

💔 Test failed - linux-rel-css
@emilio
Copy link
Member Author

emilio commented Feb 16, 2017

@bors-servo retry

#13919
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

💔 Test failed - linux-rel-css
@emilio
Copy link
Member Author

emilio commented Feb 16, 2017 •
edited

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

⌛ Testing commit 91e0ae2 with merge 35e7a4c...
bors-servo added a commit that referenced this pull request Feb 16, 2017
@bors-servo
Auto merge of #15580 - emilio:stylo, r=heycam
Loading status checks…
35e7a4c 
Bindgenup

Major pain point is that I had to write the bitfield stuff manually, but that
should be resolved soon again.

Now we generate proper layout for _every_ struct, including field offsets \o/.

r? @heycam

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15580)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: heycam
Pushing 35e7a4c to master...
@bors-servo bors-servo merged commit 91e0ae2 into servo:master Feb 16, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@emilio @highfive @heycam @bors-servo
You can’t perform that action at this time.