Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CGConstant. #15585

Merged
merged 1 commit into from Feb 20, 2017
Merged

Simplify CGConstant. #15585

merged 1 commit into from Feb 20, 2017

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 16, 2017

This change is Reviewable

@highfive
Copy link

highfive commented Feb 16, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/bindings/codegen/CodegenRust.py
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py
@highfive
Copy link

highfive commented Feb 16, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 16, 2017

@nox
Copy link
Member

nox commented Feb 16, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

📌 Commit 890273e has been approved by nox

@highfive highfive assigned nox and unassigned SimonSapin Feb 16, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

Testing commit 890273e with merge 7343958...

bors-servo added a commit that referenced this pull request Feb 16, 2017
Simplify CGConstant.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15585)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

💔 Test failed - mac-rel-css

@nox
Copy link
Member

nox commented Feb 19, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2017

Testing commit 890273e with merge 123ac5d...

bors-servo added a commit that referenced this pull request Feb 19, 2017
Simplify CGConstant.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15585)
<!-- Reviewable:end -->
@nox
Copy link
Member

nox commented Feb 19, 2017

@bors-servo retry

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Feb 20, 2017

@bors-servo clean force retry

@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2017

Testing commit 890273e with merge 634a829...

bors-servo added a commit that referenced this pull request Feb 20, 2017
Simplify CGConstant.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15585)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2017

💔 Test failed - linux-rel-css

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 20, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2017

Testing commit 890273e with merge e52eb2a...

bors-servo added a commit that referenced this pull request Feb 20, 2017
Simplify CGConstant.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15585)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2017

@bors-servo bors-servo merged commit 890273e into master Feb 20, 2017
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Checking Dependencies
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the CGConstant branch Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.