Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serde to 0.9 #15588

Merged
merged 2 commits into from Feb 18, 2017
Merged

Update serde to 0.9 #15588

merged 2 commits into from Feb 18, 2017

Conversation

@nox
Copy link
Member

nox commented Feb 16, 2017 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Feb 16, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml
  • @jgraham: components/webdriver_server/Cargo.toml
  • @emilio: components/layout/table_rowgroup.rs, components/layout/block.rs, components/layout/table_row.rs, components/layout/flow_list.rs, components/style/Cargo.toml, components/layout/Cargo.toml, components/layout/layout_debug.rs, components/layout/flow.rs, components/layout/fragment.rs, ports/geckolib/Cargo.toml
  • @fitzgen: components/devtools/actors/object.rs, components/devtools/actors/worker.rs, components/devtools_traits/Cargo.toml, components/devtools_traits/Cargo.toml, components/devtools/actors/root.rs, components/profile/Cargo.toml, components/profile_traits/Cargo.toml, components/profile_traits/Cargo.toml, components/devtools/actors/thread.rs, components/devtools/actors/framerate.rs, components/devtools/Cargo.toml, components/script_traits/lib.rs, components/script_traits/lib.rs, components/devtools/actors/console.rs, components/devtools/actor.rs, components/devtools/actors/network_event.rs, components/devtools/protocol.rs, components/devtools/actors/inspector.rs, components/script/Cargo.toml, components/devtools/actors/memory.rs, components/devtools/actors/tab.rs, components/devtools/actors/timeline.rs, components/devtools/actors/performance.rs, components/script_layout_interface/Cargo.toml, components/devtools/actors/profiler.rs, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml
  • @KiChjang: components/script_traits/lib.rs, components/script_traits/lib.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/script/Cargo.toml, components/net/Cargo.toml, components/script_layout_interface/Cargo.toml, components/net_traits/Cargo.toml, components/net_traits/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml
  • @asajeffrey: components/constellation/pipeline.rs, components/constellation/Cargo.toml, components/constellation/event_loop.rs, components/constellation/constellation.rs, components/webdriver_server/Cargo.toml
@nox
Copy link
Member Author

nox commented Feb 16, 2017

@bors-servo try

Something tells me this is not going to work on first try.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

⌛ Trying commit 240093b with merge 7a20874...
bors-servo added a commit that referenced this pull request Feb 16, 2017
@bors-servo
Auto merge of #15588 - servo:serde, r=<try>
Loading status checks…
7a20874 
Update Serde to 0.9
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

💔 Test failed - mac-dev-unit
@SimonSapin
Copy link
Member

SimonSapin commented Feb 16, 2017

Reviewed 6 of 6 files at r1, 64 of 64 files at r2.
Review status: 46 of 71 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable
@nox nox force-pushed the serde branch from 240093b to b65462d Feb 16, 2017
@nox nox force-pushed the serde branch from b65462d to ff6ed73 Feb 16, 2017
@nox
Copy link
Member Author

nox commented Feb 16, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

⌛ Trying commit ff6ed73 with merge db84b39...
bors-servo added a commit that referenced this pull request Feb 16, 2017
@bors-servo
Auto merge of #15588 - servo:serde, r=<try>
Loading status checks…
db84b39 
Update Serde to 0.9

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15588)
<!-- Reviewable:end -->
@SimonSapin SimonSapin mentioned this pull request Feb 16, 2017
Closed
4 of 4 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
State: approved= try=True
@nox
Copy link
Member Author

nox commented Feb 16, 2017

It's time.
@asajeffrey
Copy link
Member

asajeffrey commented Feb 17, 2017

Once this lands, we can land #15618.
@nox nox changed the title Update Serde to 0.9 Update serde to 0.9 Feb 18, 2017
@Ms2ger Ms2ger mentioned this pull request Feb 18, 2017
Closed
24 of 24 tasks complete
@nox
Reorder some dependencies
26d6c96
@nox nox force-pushed the serde branch 3 times, most recently from 4bda4dd to b731416 Feb 18, 2017
@SimonSapin
Copy link
Member

SimonSapin commented Feb 18, 2017

@bors-servo r+

Reviewed 1 of 1 files at r3, 49 of 73 files at r5, 24 of 24 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Feb 18, 2017

📌 Commit b731416 has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned cbrewster Feb 18, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Feb 18, 2017

⌛ Testing commit c2126e0 with merge a88b3c1...
bors-servo added a commit that referenced this pull request Feb 18, 2017
@bors-servo
Auto merge of #15588 - servo:serde, r=SimonSapin
Loading status checks…
a88b3c1 
Update serde to 0.9

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15588)
<!-- Reviewable:end -->
@nox
Update serde to 0.9 (fixes #15325)
Loading status checks…
fe3f4ff
@nox nox force-pushed the serde branch from c2126e0 to fe3f4ff Feb 18, 2017
@nox
Copy link
Member Author

nox commented Feb 18, 2017

@bors-servo r=SimonSapin

Outdated lock file...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 18, 2017

📌 Commit fe3f4ff has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Feb 18, 2017

⌛ Testing commit fe3f4ff with merge 7f3a75f...
bors-servo added a commit that referenced this pull request Feb 18, 2017
@bors-servo
Auto merge of #15588 - servo:serde, r=SimonSapin
Loading status checks…
7f3a75f 
Update serde to 0.9

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15588)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 18, 2017

💔 Test failed - linux-rel-css
@nox
Copy link
Member Author

nox commented Feb 18, 2017

This is #15583, I'm waiting for the other jobs to finish so that retry doesn't have to do everything again.
@nox
Copy link
Member Author

nox commented Feb 18, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 18, 2017

⚡ Previous build results for android, arm32, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only arm64, linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 18, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: SimonSapin
Pushing 7f3a75f to master...
@bors-servo bors-servo merged commit fe3f4ff into master Feb 18, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
This was referenced Feb 18, 2017
Merged
Closed
Closed
@nox nox deleted the serde branch Feb 18, 2017
This was referenced Feb 18, 2017
Merged
Closed
Merged
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @bors-servo @SimonSapin @asajeffrey @cbrewster
You can’t perform that action at this time.